Skip to content

Comments

local CLUSTER_ID check in CLUSTER_LIST.#2237

Open
kishiguro wants to merge 2 commits intoosrg:masterfrom
hash-set:cluster-id-check
Open

local CLUSTER_ID check in CLUSTER_LIST.#2237
kishiguro wants to merge 2 commits intoosrg:masterfrom
hash-set:cluster-id-check

Conversation

@kishiguro
Copy link
Contributor

local CLUSTER_ID check in CLUSTER_LIST should be performed to non route reflector client as well.
otherwise multi cluster configuration may have routing loop.

@kishiguro kishiguro changed the title local CLUSTER_ID check in CLUSTER_LIST check. local CLUSTER_ID check in CLUSTER_LIST. Feb 11, 2020
@fujita
Copy link
Member

fujita commented Feb 12, 2020

local CLUSTER_ID check in CLUSTER_LIST should be performed to non route reflector client as well.

Hmm, with the following description of rfc4456, I thought that only RR uses this attribute:

When an RR reflects a route, it MUST prepend the local CLUSTER_ID to
the CLUSTER_LIST. If the CLUSTER_LIST is empty, it MUST create a new
one. Using this attribute an RR can identify if the routing
information has looped back to the same cluster due to
misconfiguration.

Looks like that bird does the same:
https://github.com/CZ-NIC/bird/blob/master/proto/bgp/attrs.c#L1376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants