Skip to content

Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonesbusy merged 1 commit into from
Feb 24, 2026
Merged

Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions src/test/java/land/oras/ContainerRefTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,27 +151,28 @@ void shouldRewriteAllSubdomainToLocalProxy(@TempDir Path homeDir) throws Excepti
@Execution(ExecutionMode.SAME_THREAD)
void shouldDetermineEffectiveRegistry(@TempDir Path homeDir) throws Exception {

// Use from container ref
Registry registry = Registry.builder().defaults().build();
ContainerRef containerRef = ContainerRef.parse("docker.io/library/foo/alpine:latest@sha256:1234567890abcdef");
assertEquals("docker.io", containerRef.getEffectiveRegistry(registry));

// Took from registry
assertEquals("foo.io", containerRef.forRegistry("foo.io").getEffectiveRegistry(registry));

// Unqualified with registry
Registry registryWithRegistry =
Registry.builder().defaults().withRegistry("foo.io").build();
ContainerRef unqualifiedWithRegistryRef = ContainerRef.parse("library/foo/alpine:latest");
assertEquals("foo.io", unqualifiedWithRegistryRef.getEffectiveRegistry(registryWithRegistry));

// language=toml
// Ensure empty config does not cause error with machine contains default registry
String config = "";

TestUtils.createRegistriesConfFile(homeDir, config);

TestUtils.withHome(homeDir, () -> {

// Use from container ref
Registry registry = Registry.builder().defaults().build();
ContainerRef containerRef =
ContainerRef.parse("docker.io/library/foo/alpine:latest@sha256:1234567890abcdef");
assertEquals("docker.io", containerRef.getEffectiveRegistry(registry));

// Took from registry
assertEquals("foo.io", containerRef.forRegistry("foo.io").getEffectiveRegistry(registry));

// Unqualified with registry
Registry registryWithRegistry =
Registry.builder().defaults().withRegistry("foo.io").build();
ContainerRef unqualifiedWithRegistryRef = ContainerRef.parse("library/foo/alpine:latest");
assertEquals("foo.io", unqualifiedWithRegistryRef.getEffectiveRegistry(registryWithRegistry));

Registry r = Registry.builder().defaults().build();

// Unqualified without config use docker.io
Expand Down