Skip to content

Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent#596

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/test-dependent
Feb 24, 2026
Merged

Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent#596
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/test-dependent

Conversation

@jonesbusy
Copy link
Collaborator

Description

Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent

Testing done

Run test on a machine with custom registries.conf.

Adapt the test so it doesn't fail

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

…achine dependent

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.05%. Comparing base (f089fdb) to head (3581847).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #596      +/-   ##
============================================
+ Coverage     88.51%   89.05%   +0.53%     
  Complexity      821      821              
============================================
  Files            42       42              
  Lines          2439     2439              
  Branches        299      299              
============================================
+ Hits           2159     2172      +13     
+ Misses          168      155      -13     
  Partials        112      112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy merged commit e67d375 into oras-project:main Feb 24, 2026
8 checks passed
@jonesbusy jonesbusy deleted the feature/test-dependent branch February 24, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant