Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent#596
Merged
jonesbusy merged 1 commit intooras-project:mainfrom Feb 24, 2026
Merged
Conversation
…achine dependent Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
============================================
+ Coverage 88.51% 89.05% +0.53%
Complexity 821 821
============================================
Files 42 42
Lines 2439 2439
Branches 299 299
============================================
+ Hits 2159 2172 +13
+ Misses 168 155 -13
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update ContainerRef.shouldDetermineEffectiveRegistry test to not be machine dependent
Testing done
Run test on a machine with custom registries.conf.
Adapt the test so it doesn't fail
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR