fix(frontend): hide internal groups from add-to-group selectors#9394
fix(frontend): hide internal groups from add-to-group selectors#9394polmichel wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pass group_type__values=["default"] filter to BulkMutateGroups so the dropdown only surfaces user-assignable groups, mirroring the existing read-side filter on group_type=internal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Thread an optional filterQuery prop through DynamicRelationshipFieldProps, RelationshipManyField, and RelationshipManyInput so it reaches the existing filterQuery handling in RelationshipComboboxList. AddGroupForm now passes group_type__values=["default"] when configuring the member_of_groups picker, matching the read-side filter that already excludes internal groups from the profiles/groups card. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
group/frontend
The filter excludes groups with group_type='internal', regardless of kind — the prior wording listed specific kinds and implied a kind-based blocklist. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This PR adds a filterQuery prop to hide internal groups in group selectors, with tests verifying the behavior, and the changes are isolated to frontend UI components without affecting core business logic, database, or security-critical paths.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Shadow auto-approve: would auto-approve. The change is a well-scoped UI filtering fix that adds a filterQuery prop to hide internal groups from group selectors, includes comprehensive tests and a changelog entry, and does not affect any critical business logic or data integrity.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Shadow auto-approve: would auto-approve. This PR adds a simple filter to hide internal groups from group selectors, with test coverage and no changes to business logic, database, or critical paths, making it low-risk.
Re-trigger cubic
1 participant
Why
The single-object Manage Groups picker and the bulk Add to groups table-toolbar action both list every
CoreGroupregardless ofgroup_type, so internal groups (group_type="internal") leak into selectors where they aren't meaningfully assignable.Closes IFC-906
What changed
AddGroupForm(single-object Manage Groups picker) filters its options bygroup_type__values=["default"].ToolbarAddToGroupsAction(bulk Add to groups) passes the same filter via a newgroupsQueryFilterprop onBulkMutateGroups.filterQueryprop added toDynamicRelationshipFieldProps, threaded throughRelationshipManyField→RelationshipManyInput→RelationshipComboboxListso any field can pass GraphQL-arg filters.How to test
admin.group_type="default"should appear.Checklist
🤖 Generated with Claude Code
Summary by cubic
Hide internal groups in the Manage Groups and Add to groups selectors so only user-assignable groups (
group_type="default") appear. Closes IFC-906.AddGroupForm: passfilterQuery={{ group_type__values: ["default"] }}to the groups picker.ToolbarAddToGroupsAction: pass the same filter via newgroupsQueryFilteronBulkMutateGroups.filterQuerythroughDynamicRelationshipFieldProps→RelationshipManyField→RelationshipManyInput→RelationshipComboboxList.Written for commit 1194bfb. Summary will update on new commits.