fix(testcontainers): set TRIGGERS read batch size for Prefect backgro…#9371
Draft
fatih-acar wants to merge 1 commit into
Draft
fix(testcontainers): set TRIGGERS read batch size for Prefect backgro…#9371fatih-acar wants to merge 1 commit into
fatih-acar wants to merge 1 commit into
Conversation
…und service The task-manager-background-svc enables PREFECT_SERVER_SERVICES_TRIGGERS but doesn't tune its READ_BATCH_SIZE, unlike EVENT_PERSISTER and TASK_RUN_RECORDER. Add the missing var (default 1, override via INFRAHUB_TESTING_TASKMGR_TRIGGERS_READ_BATCH_SIZE) in both docker-compose.test.yml and docker-compose-cluster.test.yml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This change adds a new environment variable to set the triggers read batch size in testcontainers for the task-manager background service, aligning with similar settings for other Prefect services and keeping test behavior predictable.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…und service
The task-manager-background-svc enables PREFECT_SERVER_SERVICES_TRIGGERS but doesn't tune its READ_BATCH_SIZE, unlike EVENT_PERSISTER and TASK_RUN_RECORDER. Add the missing var (default 1, override via INFRAHUB_TESTING_TASKMGR_TRIGGERS_READ_BATCH_SIZE) in both docker-compose.test.yml and docker-compose-cluster.test.yml.
Why
Closes
What changed
How to review
How to test
# Commands to validateImpact & rollout
Checklist
uv run towncrier create ...)Summary by cubic
Set PREFECT_SERVER_SERVICES_TRIGGERS_READ_BATCH_SIZE for the task-manager background service in testcontainers to align with other Prefect services and keep tests predictable. Default is 1, with an override via INFRAHUB_TESTING_TASKMGR_TRIGGERS_READ_BATCH_SIZE in both docker-compose.test.yml and docker-compose-cluster.test.yml.
Written for commit f041ac0. Summary will update on new commits.
Review in cubic