planning and tasks for expanded order_by support in schemas#9344
Draft
ajtmccarty wants to merge 3 commits into
Draft
planning and tasks for expanded order_by support in schemas#9344ajtmccarty wants to merge 3 commits into
order_by support in schemas#9344ajtmccarty wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
5 issues found across 8 files
Confidence score: 4/5
- This PR looks safe to merge with low-to-moderate risk: the reported issues are documentation/spec accuracy problems (mostly 4–5/10), not direct runtime regressions in application code.
- The most significant concern is in
dev/specs/infp-530-order-by-metadata-direction/data-model.md, whereOrderDirectionis described as an existing enum even though it is not present in the codebase; this can mislead follow-up implementation work. dev/specs/infp-530-order-by-metadata-direction/plan.mdincludes dependency/version mismatches (Neo4j driver 5.28 vs project 6.0.3, Pydantic 2.10 vs supported >=2.12,<2.13) plus an unsupported Strawberry GraphQL claim, which increases planning ambiguity.- Pay close attention to
dev/specs/infp-530-order-by-metadata-direction/data-model.md,dev/specs/infp-530-order-by-metadata-direction/plan.md,dev/specs/infp-530-order-by-metadata-direction/tasks.md- align dependency/version references and task sequencing guidance before implementation.
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Shadow auto-approve: would auto-approve. This PR adds only specification and planning documents (markdown files) for a future schema feature; no code changes, no risk of breaking production logic or data integrity.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds design specs, contracts, and a task plan to extend schema
order_byto support node metadata fields and explicit sort direction, ensuring uniform ordering across list queries. Aligns with INFP-530 to let schemas default to newest-first (e.g.,created_at DESC) for cases like Documentation Notes.<attr>__value[__asc|__desc],<rel>__<attr>__value[__asc|__desc], andnode_metadata__{created_at|updated_at}[__asc|__desc](wire shape stayslist[str]).node_metadatareserved; duplicate targets rejected; inheritance unchanged and rename helper skips metadata entries.ParsedOrderByEntryincore/schema/order_by.py), contracts for grammar/errors/list paths, aquickstart, and detailed tasks/tests including changelog coverage for the precedence change.Written for commit db9e134. Summary will update on new commits. Review in cubic