Skip to content

Initial tests for git module refactoring#9323

Draft
ogenstad wants to merge 2 commits into
developfrom
pog-infp-546-tests
Draft

Initial tests for git module refactoring#9323
ogenstad wants to merge 2 commits into
developfrom
pog-infp-546-tests

Conversation

@ogenstad
Copy link
Copy Markdown
Contributor

@ogenstad ogenstad commented May 21, 2026

Why

Adds tests to capture current state and highlight things that needs to be refactored

What changed

  • Add tests for git push failures which currently show an undesired behaviour

Summary by cubic

Add Gogs-backed integration tests that pin current infrahub.git behavior across push rejections, merge failures, read-only updates, repo setup errors, and sync conflicts; push still returns True on rejection and remotes don’t advance (INFP-546 T005–T010).

Written for commit fc73474. Summary will update on new commits. Review in cubic

@github-actions github-actions Bot added group/backend Issue related to the backend (API Server, Git Agent) type/spec A specification for an upcoming change to the project labels May 21, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. This pull request only adds integration tests for git push failure scenarios and updates a documentation task list, with no changes to source code, configuration, or any production-critical logic.

Re-trigger cubic

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing pog-infp-546-tests (fc73474) with develop (248c0d1)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 5 files (changes from recent commits).

Shadow auto-approve: would auto-approve. These changes add integration tests and update a task tracking document, with no modifications to production code, infrastructure, or critical logic, so the risk of breakage is extremely low.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent) type/spec A specification for an upcoming change to the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant