fix: add labels to NodeNotFoundError for clearer messaging#9266
fix: add labels to NodeNotFoundError for clearer messaging#9266DharmaBytesX wants to merge 1 commit into
Conversation
The error message now shows Branch:, Kind:, and Identifier: labels instead of raw pipe-separated values, helping users understand which branch the lookup failed on. Fixes opsmill#5514
|
Hi! This updates the SDK submodule pointer and adds a changelog entry for the clearer NodeNotFoundError message (paired with opsmill/infrahub-sdk-python#1030). Would appreciate a review when you have a moment. Thanks! |
|
I added a comment in the SDK repo here: https://github.com/opsmill/infrahub-sdk-python/pull/1030/changes#r3256789004 It's good to see that the pipeline ran and we don't have any tests that reacts to changes in the One thing to note is that for pipelines running within this project we only ever merge the PRs that update the SDK submodule commit if those commits live in the Once the SDK PR is updated I also think we can close this commit since the change happened in that repo, and originally the issue #5514 should have been opened in the SDK repo since it's not strictly related to the Infrahub repo. (I'd not even consider that one a bug, it's more of a user preference, but it might still be nice to update the string). |
|
Thanks for the context on the submodule rule, that makes sense. I've pushed the rework on opsmill/infrahub-sdk-python#1030 addressing the review (required params on |
The error message now shows Branch:, Kind:, and Identifier: labels
instead of raw pipe-separated values, helping users understand
which branch the lookup failed on.
Before:
After:
Changes
python_sdksubmodule updated with the fixRelated
Summary by cubic
Improved NodeNotFoundError messaging by adding labels for Branch, Kind, and Identifier, replacing the ambiguous pipe-separated string. Pulls in the fix via the
python_sdksubmodule update and adds a changelog entry; fixes #5514.Written for commit 3f21188. Summary will update on new commits. Review in cubic