IFC-2339: E2E Playwright tests for webhook custom headers#8607
IFC-2339: E2E Playwright tests for webhook custom headers#8607polmichel wants to merge 6 commits intopmi-20260314-enable-cache-on-reconcile-allfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Merging this PR will improve performance by 39.04%
Performance Changes
Comparing Footnotes |
Add 3 serial E2E tests covering the full lifecycle of webhook custom headers: create a StaticKeyValue, associate it as a header on a webhook, then dissociate it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5074fed to
fdcfb29
Compare
Why
The webhook custom headers feature (INFP-445) added CoreKeyValue/CoreStaticKeyValue/CoreEnvironmentVariableKeyValue schema entities and a
headersrelationship on CoreWebhook. All backend work and unit tests are complete across PRs #8590, #8597, #8602, #8603, and #8604, but no E2E Playwright tests existed for this feature. The spec explicitly calls for E2E coverage.Closes IFC-2339
What changed
Added 3 serial E2E Playwright tests in
frontend/app/tests/e2e/webhook/webhook.spec.ts:/objects/CoreKeyValue, creates aStaticKeyValuewith name, key, and value?tab=headersURL param (Attribute-kind relationships don't render visible tabs), associates the created headerTests run serially between the existing "Access webhook" and "Delete webhook" tests, reusing the "Ansible EDA" webhook created by the existing test suite
How to review
Single file change:
frontend/app/tests/e2e/webhook/webhook.spec.tsHow to test
Impact & rollout
Checklist