Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR replaces the existing UI package under frontend/packages/ui with a new frontend/design-system package. CI was updated to target the new path and Node.js was bumped to 24. The old UI package manifest, build/config files, components, stories, and tooling configs were removed. The design-system package adds package.json, TypeScript config, Vite config, Storybook config and preview, Tailwind entry CSS, and formatter/linter configs (oxfmt, oxlint). .gitignore rules were simplified globally and augmented with design-system-specific ignores. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
frontend/design-system/oxlint.config.ts (1)
4-12: Consider downgradingnurserycategory from"error"to"warn".The
nurserycategory contains experimental and unstable rules that may change between oxlint versions. Setting it to"error"could cause unexpected CI failures after dependency updates.♻️ Proposed fix
categories: { correctness: "error", - nursery: "error", + nursery: "warn", pedantic: "error", perf: "error", restriction: "error", style: "error", suspicious: "error", },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/design-system/oxlint.config.ts` around lines 4 - 12, The oxlint config currently treats the "nursery" rules as errors which can cause CI failures for experimental rules; update the categories object in oxlint.config.ts by changing the nursery setting from "error" to "warn" (modify the categories { ..., nursery: "error", ... } entry), commit the change, and ensure any CI/lint scripts still run with the new severity.frontend/design-system/package.json (1)
18-25: Move build-only dependencies todevDependencies.
@tailwindcss/viteis a Vite plugin used only during build/development, not a runtime dependency. It should be indevDependenciesalongside the other Vite tooling.♻️ Proposed fix
"dependencies": { - "@tailwindcss/vite": "^4.2.1", "react": "^19.2.0", "react-dom": "^19.2.0", "tailwind-merge": "^3.5.0", "tailwind-variants": "^3.2.2", "tailwindcss": "^4.2.1" }, "devDependencies": { "@storybook/react-vite": "^10.2.18", + "@tailwindcss/vite": "^4.2.1", "@types/node": "^25.5.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/design-system/package.json` around lines 18 - 25, The dependency "@tailwindcss/vite" is declared under "dependencies" but is a build/dev-only Vite plugin; move it from "dependencies" to "devDependencies" in the package.json so it isn't installed at runtime—update the package.json object by removing "@tailwindcss/vite" from "dependencies" and adding the same entry under "devDependencies" alongside the existing Vite/tooling packages.frontend/design-system/vite.config.ts (1)
1-15: Missing path alias resolution for@/*imports.The
tsconfig.jsondefines a@/*→./src/*path alias (line 14-16 in tsconfig.json), but Vite won't resolve these imports at build time without additional configuration. Thefrontend/app/vite.config.tshandles this with thevite-tsconfig-pathsplugin.Either add the plugin or configure
resolve.aliasdirectly. Currently the design-system package.json doesn't includevite-tsconfig-pathsas a dependency.♻️ Proposed fix using vite-tsconfig-paths
First, add the dependency:
npm install -D vite-tsconfig-pathsThen update the config:
import tailwindcss from "@tailwindcss/vite"; import react from "@vitejs/plugin-react"; import { defineConfig } from "vite"; +import tsconfigPaths from "vite-tsconfig-paths"; // https://vite.dev/config/ export default defineConfig({ plugins: [ react({ babel: { plugins: [["babel-plugin-react-compiler"]], }, }), tailwindcss(), + tsconfigPaths(), ], });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/design-system/vite.config.ts` around lines 1 - 15, Vite config is not resolving the TypeScript path alias `@/*` defined in tsconfig, so imports will break at build; add the vite-tsconfig-paths plugin (install it as a dev dependency) and include it in the plugins array of the export in vite.config.ts (or alternatively set resolve.alias to map "@/": "./src/"); update the plugins list where react(...) and tailwindcss() are added so vite-tsconfig-paths runs before other plugins to ensure `@/*` imports resolve.frontend/design-system/tsconfig.json (1)
40-47: Consider including.storybookdirectory for type-checking.The
.storybook/main.tsand.storybook/preview.tsfiles are TypeScript but not included in the compilation scope. This means they won't benefit from the strict type-checking configured here.♻️ Proposed fix
"include": [ "src", + ".storybook", "tests/mocks", "tests/unit/components", "tests/unit/utils", "tests/unit/data", "tests/integrations/tests" ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/design-system/tsconfig.json` around lines 40 - 47, The tsconfig include array currently omits Storybook config so TypeScript won't check .storybook files; update the "include" in frontend/design-system/tsconfig.json (the include array used by the compiler) to add the ".storybook" directory so .storybook/main.ts and .storybook/preview.ts are covered by the project type-checking and strict rules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/chromatic.yml:
- Around line 16-18: The workflow's defaults.run.working-directory value is
missing the leading "./" and should be corrected; update the defaults -> run ->
working-directory entry from ".frontend/design-system" to
"./frontend/design-system" so the job runs in the intended directory (adjust the
value under the defaults.run.working-directory key in the chromatic.yml file).
In `@frontend/design-system/oxlint.config.ts`:
- Around line 13-21: The plugins array in oxlint.config.ts includes "vitest" but
vitest isn't installed; either remove the "vitest" entry from the plugins array
or install vitest as a dev dependency. To fix, edit the plugins array in
oxlint.config.ts to drop "vitest" if you don't plan to run tests, or run your
package manager to add vitest as a devDependency (e.g., npm/yarn/pnpm add -D
vitest) and update package.json accordingly so the "vitest" plugin is valid.
---
Nitpick comments:
In `@frontend/design-system/oxlint.config.ts`:
- Around line 4-12: The oxlint config currently treats the "nursery" rules as
errors which can cause CI failures for experimental rules; update the categories
object in oxlint.config.ts by changing the nursery setting from "error" to
"warn" (modify the categories { ..., nursery: "error", ... } entry), commit the
change, and ensure any CI/lint scripts still run with the new severity.
In `@frontend/design-system/package.json`:
- Around line 18-25: The dependency "@tailwindcss/vite" is declared under
"dependencies" but is a build/dev-only Vite plugin; move it from "dependencies"
to "devDependencies" in the package.json so it isn't installed at runtime—update
the package.json object by removing "@tailwindcss/vite" from "dependencies" and
adding the same entry under "devDependencies" alongside the existing
Vite/tooling packages.
In `@frontend/design-system/tsconfig.json`:
- Around line 40-47: The tsconfig include array currently omits Storybook config
so TypeScript won't check .storybook files; update the "include" in
frontend/design-system/tsconfig.json (the include array used by the compiler) to
add the ".storybook" directory so .storybook/main.ts and .storybook/preview.ts
are covered by the project type-checking and strict rules.
In `@frontend/design-system/vite.config.ts`:
- Around line 1-15: Vite config is not resolving the TypeScript path alias `@/*`
defined in tsconfig, so imports will break at build; add the vite-tsconfig-paths
plugin (install it as a dev dependency) and include it in the plugins array of
the export in vite.config.ts (or alternatively set resolve.alias to map "@/":
"./src/"); update the plugins list where react(...) and tailwindcss() are added
so vite-tsconfig-paths runs before other plugins to ensure `@/*` imports
resolve.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5604209a-f51c-49d3-9564-bb6ef0b7f656
⛔ Files ignored due to path filters (18)
frontend/design-system/package-lock.jsonis excluded by!**/package-lock.jsonfrontend/package-lock.jsonis excluded by!**/package-lock.jsonfrontend/packages/ui/package-lock.jsonis excluded by!**/package-lock.jsonfrontend/packages/ui/src/stories/assets/accessibility.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/accessibility.svgis excluded by!**/*.svgfrontend/packages/ui/src/stories/assets/addon-library.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/assets.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/context.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/discord.svgis excluded by!**/*.svgfrontend/packages/ui/src/stories/assets/docs.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/figma-plugin.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/github.svgis excluded by!**/*.svgfrontend/packages/ui/src/stories/assets/share.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/styling.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/testing.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/theming.pngis excluded by!**/*.pngfrontend/packages/ui/src/stories/assets/tutorials.svgis excluded by!**/*.svgfrontend/packages/ui/src/stories/assets/youtube.svgis excluded by!**/*.svg
📒 Files selected for processing (32)
.github/workflows/chromatic.ymlfrontend/.gitignorefrontend/design-system/.gitignorefrontend/design-system/.storybook/main.tsfrontend/design-system/.storybook/preview.tsfrontend/design-system/oxfmt.config.tsfrontend/design-system/oxlint.config.tsfrontend/design-system/package.jsonfrontend/design-system/src/index.cssfrontend/design-system/tsconfig.jsonfrontend/design-system/vite.config.tsfrontend/packages/ui/.eslintrc.cjsfrontend/packages/ui/.storybook/main.tsfrontend/packages/ui/.storybook/preview.cssfrontend/packages/ui/README.mdfrontend/packages/ui/index.tsfrontend/packages/ui/package.jsonfrontend/packages/ui/postcss.config.jsfrontend/packages/ui/src/components/Badge/Badge.stories.tsxfrontend/packages/ui/src/components/Badge/Badge.tsxfrontend/packages/ui/src/components/Badge/index.tsfrontend/packages/ui/src/index.cssfrontend/packages/ui/src/stories/Configure.mdxfrontend/packages/ui/src/stories/assets/avif-test-image.aviffrontend/packages/ui/src/tsconfig.node.jsonfrontend/packages/ui/src/utils/cn.tsfrontend/packages/ui/src/vite-env.d.tsfrontend/packages/ui/tailwind.config.jsfrontend/packages/ui/tsconfig.app.jsonfrontend/packages/ui/tsconfig.jsonfrontend/packages/ui/tsconfig.node.jsonfrontend/packages/ui/vite.config.ts
💤 Files with no reviewable changes (20)
- frontend/packages/ui/postcss.config.js
- frontend/packages/ui/src/components/Badge/index.ts
- frontend/packages/ui/src/vite-env.d.ts
- frontend/packages/ui/.eslintrc.cjs
- frontend/packages/ui/src/components/Badge/Badge.tsx
- frontend/packages/ui/tailwind.config.js
- frontend/packages/ui/src/components/Badge/Badge.stories.tsx
- frontend/packages/ui/src/index.css
- frontend/.gitignore
- frontend/packages/ui/src/utils/cn.ts
- frontend/packages/ui/index.ts
- frontend/packages/ui/README.md
- frontend/packages/ui/.storybook/main.ts
- frontend/packages/ui/tsconfig.app.json
- frontend/packages/ui/src/stories/Configure.mdx
- frontend/packages/ui/package.json
- frontend/packages/ui/tsconfig.json
- frontend/packages/ui/.storybook/preview.css
- frontend/packages/ui/vite.config.ts
- frontend/packages/ui/tsconfig.node.json
pa-lem
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setup storybook and CI for it. Currently the storybook is empty. Components will be added in futur PRs.
Summary by CodeRabbit
New Features
Chores