chore: add PR template and issue templates#4091
chore: add PR template and issue templates#4091swcurran merged 6 commits intoopenwallet-foundation:mainfrom
Conversation
Chaithanya5gif
force-pushed
the
chore/add-pr-template
branch
from
a77e813 to
3c0da7f
Compare
|
Hey, I've fixed the DCO issue. Could someone please review this PR? Thank you! |
Signed-off-by: chaithanya <chaithanyyal55@gmail.com>
Signed-off-by: chaithanya <chaithanyyal55@gmail.com>
Chaithanya5gif
force-pushed
the
chore/add-pr-template
branch
from
3c0da7f to
8474100
Compare
|
Will do. How come you are submitting this PR? Are you/your team using ACA-Py? |
| url: https://acapy.org | ||
| about: Check the docs before opening an issue | ||
| - name: Community Discord | ||
| url: https://discord.gg/hyperledger |
There was a problem hiding this comment.
This URL is wrong as well. Checking to find the right one.
|
How does a PR template work when I use gh to submit my PRs via the command line. Does gh pick up the template? |
|
Hi @swcurran, thank you so much for the review! I'm a first-time open source contributor and I really appreciate your feedback,I came across the ACA-Py repo and noticed there were no PR or issue templates, so I thought it would be a great way to make my first contribution and I'll fix the Documentation URL to https://aca-py.org, update the Discord URL to https://discord.gg/openwalletfoundation, and add the breaking change note all in one clean commit!. |
|
I looked into this — gh pr create interactively does pick up the template automatically. However, using the --fill flag skips it, which is a known gh CLI limitation. You can also explicitly pass it with --template .github/pull_request_template.md if needed |
Signed-off-by: chaithanya <chaithanyyal55@gmail.com>
Chaithanya5gif
force-pushed
the
chore/add-pr-template
branch
from
c75a3c3 to
71c8d4b
Compare
|
i have pushed the fixes, updated both URLs and added the breaking change note. Please let me know if anything else needs to be changed. |
| about: Check the docs before opening an issue | ||
| - name: Community Discord | ||
| url: https://discord.gg/openwalletfoundation | ||
| about: Ask questions in the Hyperledger Discord |
There was a problem hiding this comment.
Sorry -- missed this one first time around. Should be "in the aca-py channel on the OpenWallet Foundation Discord Server"
There was a problem hiding this comment.
Done! Updated,Let me know if anything else needs to be changed
Signed-off-by: chaithanya <chaithanyyal55@gmail.com>
|
3 participants
What does this PR do?
This PR addresses the missing items in the repository's Community Standards checklist.
Changes
.github/pull_request_template.mdto standardize PR submissions.github/ISSUE_TEMPLATE/bug_report.mdfor bug reports.github/ISSUE_TEMPLATE/feature_request.mdfor feature requests.github/ISSUE_TEMPLATE/config.ymlto configure the issue template chooserWhy?
The Community Standards checklist at github.com/openwallet-foundation/acapy/community
showed these as missing. This improves the contributor experience.