lvms-zstream: make releases list configurable via environment variable

[kasturinarra]

Replace hardcoded RELEASES list with LVMS_ZSTREAM_RELEASES env var so adding or removing a release is a one-line CI config change.

Summary by CodeRabbit

Updated the OpenShift CI infrastructure for the lvms-zstream component so the z-stream trigger no longer uses a hardcoded list of OpenShift releases. The CI config now sets a LVMS_ZSTREAM_RELEASES environment variable (comma-separated versions) that the trigger step reads to decide which releases to check, and the trigger script fails fast if the variable is missing/empty. As a result, changing the release set is now a one-line CI configuration update rather than a code change.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 939a7805-9e3e-4bc4-823c-a42db14d8bdc

📥 Commits

Reviewing files that changed from the base of the PR and between 8a7c4fc and 7f6839d.

📒 Files selected for processing (3)

• ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main__zstream.yaml
• ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-commands.sh
• ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-ref.yaml

✅ Files skipped from review due to trivial changes (1)

• ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main__zstream.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-ref.yaml
• ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-commands.sh

---

Walkthrough

Adds LVMS_ZSTREAM_RELEASES to the LVMS zstream trigger setup, sets it in the job config, and makes the trigger script require it instead of using a hard-coded release default.

Changes

LVMS zstream env wiring

Layer / File(s)	Summary
Env wiring and validation ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-ref.yaml, ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main__zstream.yaml, ci-operator/step-registry/lvms/zstream/trigger/lvms-zstream-trigger-commands.sh	Declares LVMS_ZSTREAM_RELEASES in the step ref, sets it to a comma-separated release list in the job config, and requires it at script startup before assigning RELEASES.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#81376: This PR also changes the LVMS z-stream trigger plumbing around release selection and the trigger script.

Suggested labels: rehearsals-ack

Suggested reviewers: jaypoulz, eggfoobar

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: moving the lvms-zstream release list to a configurable environment variable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only updates CI config and trigger scripts; no Ginkgo test titles were added or modified, so no dynamic test-name risk.
Test Structure And Quality	✅ Passed	No Ginkgo test files or assertions were changed; this PR only updates CI config and a trigger shell script.
Microshift Test Compatibility	✅ Passed	PR only changes CI env/config and a shell script; no new Ginkgo tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only CI config and a shell trigger script changed; no new Ginkgo tests or node/topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Patch only replaces a hardcoded release list with an env var in CI scripts/config; no affinity, selectors, replicas, or topology scheduling logic changed.
Ote Binary Stdout Contract	✅ Passed	Touched files are CI shell/YAML only; no Go main/init/TestMain or top-level stdout writes were added, and shell logging goes to stderr.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo/e2e tests were added; the PR only parameterizes existing LVMS zstream CI trigger config, so the IPv6/disconnected test check is not applicable.
No-Weak-Crypto	✅ Passed	No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto changes were introduced; diff only adds env-driven release config.
Container-Privileges	✅ Passed	PASS: The PR only adds an env var and shell guard; the touched files have no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	No new log statements expose secrets, PII, tokens, or internal hostnames; added logging is limited to releases, PR info, digests, and local paths.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign brandisher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/lvm-operator/OWNERS
• ci-operator/step-registry/lvms/zstream/trigger/OWNERS [kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kasturinarra: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-lvm-operator-main-zstream-trigger	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[kasturinarra]

/pj-rehearse periodic-ci-openshift-lvm-operator-main-zstream-trigger

[openshift-merge-bot]

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.