Skip to content

Add rosa-e2e-ocm-fvt-longrunning step ref for OSDFM long running jobs#81457

Open
anfranci14 wants to merge 1 commit into
openshift:mainfrom
anfranci14:ROSAENG-60420-add-rosa-e2e-ocm-fvt-longrunning-step-ref
Open

Add rosa-e2e-ocm-fvt-longrunning step ref for OSDFM long running jobs#81457
anfranci14 wants to merge 1 commit into
openshift:mainfrom
anfranci14:ROSAENG-60420-add-rosa-e2e-ocm-fvt-longrunning-step-ref

Conversation

@anfranci14

@anfranci14 anfranci14 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Add a dedicated 'rosa-e2e-ocm-fvt-longrunning' step registry ref with a 12h step timeout and point OSDFM SC/MC autoscaling integration jobs at it.

OSDFM SC autoscaling Prow job is killed at 5h by the shared rosa-e2e-ocm-fvt step ref, even though the ci-operator test config sets timeout: 12h0m0s.
Step-level timeout takes precedence over test-level timeout. Per-job step timeout override from ci-operator config is not supported.

Recent failure (periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-integration-ocm-fvt-periodic-osdfm-sc-autoscaling-integration):

  • Steps 1–2 completed in ~20m
  • Step 3 (dormant SC polling, up to 6h) ran until the 5h step kill
  • Post-dormant verification never executed
    The shared ref was raised to 5h in #80225 for upgrade/autonode jobs; OSDFM autoscaling needs more headroom.

Solution

new step variant:

  • rosa-e2e-ocm-fvt-longrunning-ref.yaml — same as rosa-e2e-ocm-fvt, reuses rosa-e2e-ocm-fvt-commands.sh, timeout: 12h0m0s
  • __ocm-fvt-osdfm-integration.yaml — SC + MC autoscaling jobs use ref: rosa-e2e-ocm-fvt-longrunning

Keep rosa-e2e-ocm-fvt-longrunning-ref.yaml in sync with rosa-e2e-ocm-fvt-ref.yaml .Both share the same commands script.

Summary by CodeRabbit

This updates OpenShift CI configuration for the ROSA OCM FVT OSDFM autoscaling jobs to use a new long-running step-registry reference with a 12-hour step timeout. The new rosa-e2e-ocm-fvt-longrunning registry entry reuses the existing FVT command script, but extends the step-level timeout so long-running SC/MC autoscaling integrations are no longer cut off by the shorter shared timeout. It also adds the corresponding step-registry metadata and ownership wiring for the new reference.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e73fe700-b446-443b-8447-e0b9d07c4c9f

📥 Commits

Reviewing files that changed from the base of the PR and between fe708ad and d99b4f4.

📒 Files selected for processing (5)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-integration.yaml
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/OWNERS
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/rosa-e2e-ocm-fvt-longrunning-commands.sh
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/rosa-e2e-ocm-fvt-longrunning-ref.metadata.json
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/rosa-e2e-ocm-fvt-longrunning-ref.yaml
✅ Files skipped from review due to trivial changes (3)
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/OWNERS
  • ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/rosa-e2e-ocm-fvt-longrunning-ref.metadata.json
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-integration.yaml

Walkthrough

Adds a new CI step-registry entry rosa-e2e-ocm-fvt-longrunning with a 12h timeout, nested podman execution, credential mounts, and environment variables, implemented via symlinked OWNERS/commands files and new metadata/ref YAML. Two periodic osdfm autoscaling test configs are updated to reference this new step.

Changes

Long-running OCM FVT step registry

Layer / File(s) Summary
New longrunning step-registry definition
ci-operator/step-registry/rosa/e2e/ocm-fvt/longrunning/rosa-e2e-ocm-fvt-longrunning-ref.yaml, ...-ref.metadata.json, .../OWNERS, .../rosa-e2e-ocm-fvt-longrunning-commands.sh
Adds a new step with 12h timeout/30s grace period, nested podman, credential mounts, resource requests, and env vars; OWNERS and commands script are symlinks to parent versions; metadata defines approvers/reviewers.
Repoint periodic test configs
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-osdfm-integration.yaml
Updates two periodic osdfm autoscaling integration test entries to use the new rosa-e2e-ocm-fvt-longrunning ref instead of rosa-e2e-ocm-fvt.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related PRs: None identified.

Suggested labels: ci-operator, step-registry

Suggested reviewers: bmeng, dustman9000, gdbranco, jfrazierredhat, ravitri, tiwillia

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a long-running rosa-e2e-ocm-fvt step ref for OSDFM jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes ci-operator YAML/symlinks and static job/ref names; no Ginkgo It/Describe/When titles or dynamic identifiers were added.
Test Structure And Quality ✅ Passed PASS: The PR only changes ci-operator/step-registry YAML/JSON and symlinks; no Ginkgo test code or It blocks were added or modified.
Microshift Test Compatibility ✅ Passed The PR only changes CI/step-registry YAML and symlinks; no new or modified Ginkgo tests were added, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes ci-operator/step-registry configs and a shell ref; no new Ginkgo e2e tests or SNO-sensitive specs were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator/step-registry timeout/ref wiring changed; no nodeSelector, affinity, spread, tolerations, or topology-aware scheduling logic was added.
Ote Binary Stdout Contract ✅ Passed Diff only adds step-registry YAML/symlinks; no Go/binary process-level code or stdout setup was changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo test code or IPv4/external-network assumptions were added; the longrunning ref reuses the existing shared command script.
No-Weak-Crypto ✅ Passed Touched files only add a longrunning step ref and job timeout updates; no MD5/SHA1/DES/RC4/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed No privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were added; changes only add a longrunning ref and retarget jobs.
No-Sensitive-Data-In-Logs ✅ Passed No new log statements or debug output were added; the PR only switches jobs to a longrunning ref and reuses the existing command script.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from gdbranco and tiwillia July 3, 2026 18:00
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anfranci14
Once this PR has been reviewed and has the lgtm label, please assign tiwillia for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@anfranci14, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: name of reference in file /var/tmp/gitrepo2750849334/ci-operator/step-registry/rosa/e2e/ocm-fvt/rosa-e2e-ocm-fvt-longrunning-ref.yaml should be rosa-e2e-ocm-fvt
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@anfranci14 anfranci14 force-pushed the ROSAENG-60420-add-rosa-e2e-ocm-fvt-longrunning-step-ref branch from fe708ad to d99b4f4 Compare July 3, 2026 20:31
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@anfranci14: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-integration-ocm-fvt-periodic-osdfm-mc-autoscaling-integration N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-osdfm-integration-ocm-fvt-periodic-osdfm-sc-autoscaling-integration N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@anfranci14: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant