Skip to content

remove dtrifiro from opendatahub/red-hat-data-services owners#81456

Open
dtrifiro wants to merge 1 commit into
openshift:mainfrom
dtrifiro:remove-dtrifiro-from-owners
Open

remove dtrifiro from opendatahub/red-hat-data-services owners#81456
dtrifiro wants to merge 1 commit into
openshift:mainfrom
dtrifiro:remove-dtrifiro-from-owners

Conversation

@dtrifiro

@dtrifiro dtrifiro commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Removed dtrifiro from OWNERS files across Open Data Hub and Red Hat Data Services CI configuration, affecting approval/review ownership for the caikit-nlp, vllm-gaudi, text-generation-inference, and vllm component repos in both generated Prow configs and source config manifests. This updates who can approve or review CI/infrastructure changes for those areas without changing any other ownership entries.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 46ca3ba7-9fc2-4e8c-8fa2-c5f92aba37d7

📥 Commits

Reviewing files that changed from the base of the PR and between 33d91b3 and c0d53ae.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/opendatahub-io/caikit-nlp/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/opendatahub-io/vllm-gaudi/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/red-hat-data-services/text-generation-inference/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/red-hat-data-services/vllm/OWNERS is excluded by !ci-operator/jobs/**
📒 Files selected for processing (7)
  • ci-operator/config/opendatahub-io/caikit-nlp/OWNERS
  • ci-operator/config/opendatahub-io/vllm-gaudi/OWNERS
  • ci-operator/config/red-hat-data-services/text-generation-inference/OWNERS
  • core-services/prow/02_config/opendatahub-io/caikit-nlp/OWNERS
  • core-services/prow/02_config/opendatahub-io/vllm-gaudi/OWNERS
  • core-services/prow/02_config/red-hat-data-services/text-generation-inference/OWNERS
  • core-services/prow/02_config/red-hat-data-services/vllm/OWNERS
💤 Files with no reviewable changes (7)
  • ci-operator/config/opendatahub-io/caikit-nlp/OWNERS
  • core-services/prow/02_config/opendatahub-io/vllm-gaudi/OWNERS
  • core-services/prow/02_config/red-hat-data-services/text-generation-inference/OWNERS
  • core-services/prow/02_config/opendatahub-io/caikit-nlp/OWNERS
  • ci-operator/config/opendatahub-io/vllm-gaudi/OWNERS
  • ci-operator/config/red-hat-data-services/text-generation-inference/OWNERS
  • core-services/prow/02_config/red-hat-data-services/vllm/OWNERS

Walkthrough

The user dtrifiro is removed from the approvers and reviewers lists in seven OWNERS files covering caikit-nlp, vllm-gaudi, text-generation-inference, and vllm across both ci-operator and core-services/prow configuration directories. No other entries are changed.

Changes

OWNERS Access Removal

Layer / File(s) Summary
caikit-nlp OWNERS
ci-operator/config/opendatahub-io/caikit-nlp/OWNERS, core-services/prow/02_config/opendatahub-io/caikit-nlp/OWNERS
Removes dtrifiro from approvers and reviewers lists.
vllm-gaudi OWNERS
ci-operator/config/opendatahub-io/vllm-gaudi/OWNERS, core-services/prow/02_config/opendatahub-io/vllm-gaudi/OWNERS
Removes dtrifiro from approvers and reviewers lists.
text-generation-inference OWNERS
ci-operator/config/red-hat-data-services/text-generation-inference/OWNERS, core-services/prow/02_config/red-hat-data-services/text-generation-inference/OWNERS
Removes dtrifiro from approvers and reviewers lists.
vllm OWNERS
core-services/prow/02_config/red-hat-data-services/vllm/OWNERS
Removes dtrifiro from approvers and reviewers lists.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly describes the main change of removing dtrifiro from OWNERS files, though it omits the core-services/prow path updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test declarations were changed; the PR only touches OWNERS/CI config files and has no It/Describe/Context/When matches.
Test Structure And Quality ✅ Passed PR only removes dtrifiro from OWNERS files; no Ginkgo test files or test code changed.
Microshift Test Compatibility ✅ Passed No Go test code changed and the patch adds no new Ginkgo declarations or MicroShift guards; changes are CI/OWNERS config only.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only edits OWNERS metadata; no Ginkgo e2e tests were added or modified, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only edits OWNERS membership files; no deployment manifests, operators, or controllers are changed, so no scheduling/topology constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only edits OWNERS metadata; no OTE binary code or stdout-producing process setup was changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR changes OWNERS/CI config only; no new Ginkgo test bodies or IPv4/public-internet assumptions were added.
No-Weak-Crypto ✅ Passed Changed OWNERS files only adjust approver/reviewer usernames; no weak-crypto terms, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed Only OWNERS files changed; no container/K8s manifests or privilege fields were modified.
No-Sensitive-Data-In-Logs ✅ Passed PR only removes dtrifiro from OWNERS files; no logging code or sensitive-data strings were added in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from RH-steve-grubb and heyselbi July 3, 2026 16:57
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dtrifiro: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@dtrifiro: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant