Skip to content

CNTRLPLANE-3713: ci(openshift-tests-private): remove azure-aks-hypershift-disaster-rec…#81438

Open
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:CNTRLPLANE-3713_migrate_shared_ingress
Open

CNTRLPLANE-3713: ci(openshift-tests-private): remove azure-aks-hypershift-disaster-rec…#81438
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:CNTRLPLANE-3713_migrate_shared_ingress

Conversation

@mgencur

@mgencur mgencur commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

…overy-infra-guest-f14 periodic test

Remove the disaster-recovery-infra-guest nodepool autorepair test from all release branches (4.19, 4.20, 4.21, 4.22, 5.0). This test validates MHC-based machine autorepair on Azure AKS HyperShift but is redundant with existing coverage in the hypershift repo's e2e suite.

Removes both CI operator configs and generated Prow periodic jobs.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3713

More information about the current coverage upstream is in this comment on the JIRA.

Summary by CodeRabbit

This PR removes the azure-aks-hypershift-disaster-recovery-infra-guest-f14 periodic test from OpenShift CI for the affected release branches (4.19, 4.20, 4.21, 4.22, and 5.0).

In practice, that means:

  • the CI operator configs no longer define or schedule this Azure AKS HyperShift disaster-recovery job
  • the corresponding generated Prow periodic jobs are removed as well

The removed coverage was for MHC-based machine autorepair on Azure AKS HyperShift, and the change treats it as redundant with the existing hypershift repo e2e suite.

…overy-infra-guest-f14 periodic test

Remove the disaster-recovery-infra-guest nodepool autorepair test from
all release branches (4.19, 4.20, 4.21, 4.22, 5.0). This test validates
MHC-based machine autorepair on Azure AKS HyperShift but is redundant
with existing coverage in the hypershift repo's e2e suite.

Removes both CI operator configs and generated Prow periodic jobs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mgencur mgencur changed the title ci(openshift-tests-private): remove azure-aks-hypershift-disaster-rec… CNTRLPLANE-3713: ci(openshift-tests-private): remove azure-aks-hypershift-disaster-rec… Jul 3, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references CNTRLPLANE-3713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

…overy-infra-guest-f14 periodic test

Remove the disaster-recovery-infra-guest nodepool autorepair test from all release branches (4.19, 4.20, 4.21, 4.22, 5.0). This test validates MHC-based machine autorepair on Azure AKS HyperShift but is redundant with existing coverage in the hypershift repo's e2e suite.

Removes both CI operator configs and generated Prow periodic jobs.

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-3713

More information about the current coverage upstream is in this comment on the JIRA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jadhaj and sergiordlr July 3, 2026 11:02
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign asood-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0f3dcacf-bdec-41cf-94a9-40e626f5e12b

📥 Commits

Reviewing files that changed from the base of the PR and between fc62cbb and ba7f182.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
💤 Files with no reviewable changes (5)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml

Walkthrough

This PR removes the azure-aks-hypershift-disaster-recovery-infra-guest-f14 test job configuration from five openshift-tests-private nightly release config files (4.19, 4.20, 4.21, 4.22, 5.0). The 4.20 file additionally adds new Azure AKS Hypershift guest job variants and an AWS IPI OVN Hypershift job entry.

Changes

Nightly config test job removal

Layer / File(s) Summary
Remove disaster-recovery-infra-guest-f14 job
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yaml, ...release-4.21__amd64-nightly.yaml, ...release-4.22__amd64-nightly.yaml, ...release-5.0__amd64-nightly.yaml
Removes the azure-aks-hypershift-disaster-recovery-infra-guest-f14 job block (cron, reporter config, env settings, test chain, and workflow) from each config's tests list.
Replace removed job with new guest variants in 4.20
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml
Removes the same disaster-recovery-infra-guest-f14 job and adds new azure-aks-hypershift guest job entries plus an aws-ipi-ovn-hypershift-guest-disable-caps-f14 job.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: lgtm, approved

Suggested reviewers: AlexVulaj, msugakov, janisz

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the Azure AKS HyperShift disaster-recovery periodic test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only static CI job entries were removed from YAML; no Ginkgo It/Describe/When titles were added or modified, so no unstable test names are introduced.
Test Structure And Quality ✅ Passed PR only removes ci-operator and generated periodic YAML; no Ginkgo/Go test code is changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only removes CI YAML job entries; no new Ginkgo tests or unsupported MicroShift APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo test code was added; the PR only removes periodic job YAML entries, so SNO compatibility checks don’t apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only deletes CI periodic job definitions/configs; no manifests, controllers, or scheduling logic were added or modified, so no topology-aware scheduling risk.
Ote Binary Stdout Contract ✅ Passed PR only removes YAML CI/job entries; no process-level code or stdout writes were added or modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only deletes YAML periodic job definitions; it adds no new Ginkgo tests or networking logic, so this IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed Only job/config deletions were made; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed Touched YAMLs only remove a periodic job; no added manifests contain privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only removes periodic job entries/configs; no secrets, PII, or sensitive log content are added in the changed files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@mgencur

mgencur commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@bryan-cox Please let me know if we first need to implement https://redhat.atlassian.net/browse/CNTRLPLANE-2877
After merging the current PR, the auto-repair tests won't run on AKS but since nobody was watching them for a long time, it should be fine if CNTRLPLANE-2877 is implemented a little later. Thanks

@mgencur

mgencur commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants