Add ec2:CreateSnapshot to AWS minimal permissions#81427
Add ec2:CreateSnapshot to AWS minimal permissions#81427YamunadeviShanmugam wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe minimal AWS permissions list for OpenShift versions earlier than 4.18 adds two EC2 snapshot actions. ChangesAWS minimal permissions update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse auto-ack |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test e2e-aws-csi |
|
@ropatil010: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/pj-rehearse |
|
@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Yamunadevi Shanmugam <yshanmug@redhat.com>
7cd2f80 to
01ae16b
Compare
|
[REHEARSALNOTIFIER]
A total of 12815 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ropatil010: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test ci/rehearse/devfile/registry-operator/main/v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse ci/rehearse/devfile/registry-operator/main/v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@YamunadeviShanmugam: job(s): ci/rehearse/devfile/registry-operator/main/v4.18-registry-operator-integration-test either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-rehearse-devfile-registry-operator-main-v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@YamunadeviShanmugam: job(s): pull-ci-rehearse-devfile-registry-operator-main-v4.18-registry-operator-integration-test either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-devfile-registry-operator-main-v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
|
/pj-rehearse pull-ci-openshift-gcp-workload-identity-federation-webhook-main-okd-scos-e2e-aws-ovn |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gangwgr, patrickdillon, YamunadeviShanmugam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests pull-ci-devfile-registry-operator-main-v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests pull-ci-openshift-grafana-tempo-operator-main-upstream-ocp-4.12-amd64-tempo-upstream-tests pull-ci-devfile-registry-operator-main-v4.18-registry-operator-integration-test |
|
@YamunadeviShanmugam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@YamunadeviShanmugam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
CI jobs are failing with Snapshot creation issues
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/31310/pull-ci-openshift-origin-main-e2e-aws-csi/2072840424191430656
This adds fix to add those permission
Summary by CodeRabbit
This change updates the AWS minimal-permissions CI setup used by OpenShift test jobs by granting
ec2:CreateSnapshot. In practical terms, it expands the IAM policy for older OpenShift AWS environments so EBS CSI snapshot-related tests can create volume snapshots successfully, helping resolve the observed CI failures around snapshot creation, restore, and deletion.