HOLD: CRO upgrade test rehearsal (maxcao13 fork)

[maxcao13]

/hold

Rehearsal PR for testing OLM upgrade e2e changes in maxcao13/cluster-resource-override-admission-operator (olm-bundle-upgrades branch).

Not intended to merge.

Made with Cursor

Summary by CodeRabbit

This change adds a rehearsal CI workflow for maxcao13/cluster-resource-override-admission-operator to validate OLM bundle upgrade behavior using the olm-bundle-upgrades upgrade branch.

Practically, it updates the CI Operator configuration to:

• define an OLM bundle-upgrade pipeline that wires the operator, operand, and registry images for tests (including pinned “previous” bundle/operator/operand images from the ocp/4.22 tags to avoid stale image references)
• run unit and verification steps, plus AWS-based E2E suites (e2e-aws-operator and e2e-aws-olm)
• execute an explicit upgrade E2E rehearsal flow (e2e-aws-upgrade) that:
  • installs the previous bundle (allowed to fail), locates the resulting CSV, and patches the CSV’s deployment container image and operand env var to the promoted images
  • deletes and waits for the deployment to re-create
  • runs upgrade pre-checks, performs bundle-upgrade via operator-sdk, then runs upgrade post-checks and full make e2e

The configuration is released under ocp for version 5.0 (with a latest integration) and sets baseline resource requests for CI-managed resources.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[maxcao13]

/hold

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c026f5be-5249-4d62-b277-3cd67e36876e

📥 Commits

Reviewing files that changed from the base of the PR and between 9565192 and 5cc8ec5.

📒 Files selected for processing (1)

• ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml

---

Walkthrough

Adds a CI Operator config for the cluster-resource-override-admission-operator OLM bundle-upgrade workflow. It sets image inputs, test jobs, an AWS upgrade path, dependency verification, and generated metadata.

Changes

OLM Bundle Upgrade CI Configuration

Layer / File(s)	Summary
Base images and bundle wiring ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml	Sets the CI base image, previous bundle/operator/operand pins, build outputs, bundle substitutions, and release integration.
Shared resource defaults and basic tests ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml	Applies global resource requests, defines the binary build command, and adds unit and verify test steps.
AWS operator and OLM E2E tests ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml	Adds the e2e-aws-operator and e2e-aws-olm jobs with ipi-aws, CI image dependencies, and per-test CPU requests.
Upgrade workflow ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml	Defines the e2e-aws-upgrade flow from previous bundle install through CSV patching, deployment recreation, and upgrade validation steps.
Dependency verification and metadata ci-operator/config/maxcao13/cluster-resource-override-admission-operator/maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades.yaml	Adds verify-deps and generated branch, org, and repo metadata.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is related to the PR’s main purpose: a rehearsal for CRO OLM upgrade testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only changes a CI config YAML; no Ginkgo test titles or dynamic test-name strings are present.
Test Structure And Quality	✅ Passed	Only a ci-operator YAML changed; no Ginkgo test code was added or modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo test code was added; the PR only changes CI operator YAML, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a CI operator YAML changed; no Ginkgo e2e specs were added, so there are no new SNO assumptions to review.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR touches only a CI operator config file, and it contains no anti-affinity, topology spread, nodeSelector, tolerations, or PDB changes.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only changes a ci-operator YAML config; no process-level binary code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a CI YAML changed; no new Ginkgo e2e test code was added, and the job uses cluster-internal CI images.
No-Weak-Crypto	✅ Passed	The only changed file is a CI YAML config; its diff and contents contain no weak-crypto APIs, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	No privileged/root-host settings were added; the new CI config only uses --security-context-config restricted and resource requests.
No-Sensitive-Data-In-Logs	✅ Passed	The new CI config has no echo/printf/debug logging or secret-like terms; its commands only reference image pullspecs and a namespace, not sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maxcao13]

/pj-rehearse pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-upgrade

[openshift-merge-bot]

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[maxcao13]

/pj-rehearse pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-upgrade

[openshift-merge-bot]

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-ci-bundle-cluster-resource-override-admission-operator-bundle	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-olm	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-operator	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-upgrade	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-images	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-unit	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-verify	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed
pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-verify-deps	maxcao13/cluster-resource-override-admission-operator	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[maxcao13]

/pj-rehearse pull-ci-maxcao13-cluster-resource-override-admission-operator-olm-bundle-upgrades-e2e-aws-upgrade

[openshift-merge-bot]

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.