Skip to content

fix: update multicluster-global-hub Prow builder to go1.25-linux for release-2.12 to release-2.17#79301

Open
birsanv wants to merge 1 commit into
openshift:mainfrom
birsanv:fix/multicluster-global-hub-go1.25-prow-config
Open

fix: update multicluster-global-hub Prow builder to go1.25-linux for release-2.12 to release-2.17#79301
birsanv wants to merge 1 commit into
openshift:mainfrom
birsanv:fix/multicluster-global-hub-go1.25-prow-config

Conversation

@birsanv
Copy link
Copy Markdown
Contributor

@birsanv birsanv commented May 14, 2026

Summary

All multicluster-global-hub release branches (2.12–2.17) already use Go 1.25.x in go.mod, but the Prow CI configs still reference older builders (go1.22-linux, go1.23-linux, go1.24-linux).

This PR updates all six release branch configs to use go1.25-linux, consistent with other stolostron projects on the same branches (e.g. multiclusterhub-operator, governance-policy-addon-controller).

Changes

Branch Before After
release-2.12 go1.23-linux go1.25-linux
release-2.13 go1.23-linux go1.25-linux
release-2.14 go1.22-linux go1.25-linux
release-2.15 go1.24-linux / go1.22-linux go1.25-linux
release-2.16 go1.24-linux / go1.22-linux go1.25-linux
release-2.17 go1.24-linux / go1.22-linux go1.25-linux

Verification

  • go1.25-linux is already used by other stolostron projects on release-2.12 (e.g. multiclusterhub-operator) and on older backplane branches
  • All affected branches have go 1.25.x in their go.mod

Made with Cursor

Updates the CI/Prow builder configuration for the stolostron multicluster-global-hub repository across release branches 2.12 through 2.17 to use the go1.25-linux builder image.

What's changing

This PR synchronizes the Go toolchain version used by Prow CI with the actual Go version requirements declared in the project. All six affected release branches (2.12, 2.13, 2.14, 2.15, 2.16, 2.17) have Go 1.25.x specified in their go.mod files, but their CI configurations were still referencing older builder images:

  • Releases 2.12 and 2.13: Updates from go1.23-linux to go1.25-linux
  • Releases 2.14, 2.15, 2.16, and 2.17: Updates from go1.22-linux or go1.24-linux to go1.25-linux

Why this matters

The mismatch between the declared Go version and the CI builder image was causing build and test failures. By updating the Prow builder configuration to match the actual Go 1.25.x requirements, builds will now use the correct Go compiler version, resolving these failures.

Implementation details

Six CI configuration files in ci-operator/config/stolostron/multicluster-global-hub/ are modified to set build_root.image_stream_tag.tag to go1.25-linux. The go1.25-linux builder is already in use by other stolostron projects on the same release branches, establishing this as the standard build environment for the group.

…release-2.12 through release-2.17

All release branches (2.12-2.17) already use Go 1.25.x in go.mod but
the Prow CI configs still reference go1.22/1.23/1.24-linux builders,
causing build/test failures. Update all six release branch configs to
use go1.25-linux, consistent with other stolostron projects on the
same branches (e.g. multiclusterhub-operator, governance-policy-addon-controller).

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0abb2bbf-3bde-4584-a827-fd8b82e92324

📥 Commits

Reviewing files that changed from the base of the PR and between 55c6069 and 23d1bc3.

📒 Files selected for processing (6)
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.12.yaml
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.13.yaml
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.14.yaml
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.15.yaml
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.16.yaml
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.17.yaml

Walkthrough

Go builder image tags are upgraded from various versions (1.22–1.24) to 1.25 across six release pipeline configurations (2.12–2.17) for the stolostron multicluster-global-hub CI operator. Only build_root.image_stream_tag and related builder image definitions are modified.

Changes

Go 1.25 Builder Image Upgrade Across Release Configs

Layer / File(s) Summary
Builder image tag updates (releases 2.12–2.17)
ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.1[2-7].yaml
Consistent upgrade pattern: build_root.image_stream_tag.tag changed from go1.22-linux, go1.23-linux, or go1.24-linux to go1.25-linux; related builder image definitions (stolostron_builder_go1.25-linux) added or updated where applicable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • rokej
  • mikeshng
  • dhaiducek
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating Go builder version from various older versions to go1.25-linux across multiple release branches for the multicluster-global-hub project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only modifies OpenShift CI operator configuration YAML files to update Go builder image references. No Ginkgo test files or test name definitions are present, so the check is not applicable.
Test Structure And Quality ✅ Passed This PR only changes CI/Prow YAML configuration files, not Ginkgo test code. The custom check requires reviewing Ginkgo tests, which are not present in these changes.
Microshift Test Compatibility ✅ Passed This PR modifies only Prow CI configuration YAML files and does not add any new Ginkgo e2e tests. The MicroShift Test Compatibility check applies only to new test code, making it not applicable here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only CI/Prow builder configuration files (YAML) to update Go versions from 1.22-1.24 to 1.25. No new Ginkgo e2e tests are added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI-operator configuration files to update Go builder image tags. No deployment manifests, operator code, or controllers are changed. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration files, not executable Go code. OTE Binary Stdout Contract check applies to process-level code, not CI configuration.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to YAML CI configuration files updating Go builder image versions. The IPv6/disconnected network compatibility check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bjoydeep and smithbw88 May 14, 2026 13:09
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@birsanv: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-global-hub-release-2.13-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.13-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.13-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.13-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.13-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.16-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.12-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.12-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.12-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.12-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.12-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.17-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.17-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.17-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.17-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.17-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed

A total of 30 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@birsanv: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@birsanv
Copy link
Copy Markdown
Contributor Author

birsanv commented May 14, 2026

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@birsanv
Copy link
Copy Markdown
Contributor Author

birsanv commented May 14, 2026

/assign @sahare

Copy link
Copy Markdown
Contributor

@sahare sahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
Copy link
Copy Markdown

@bjoydeep bjoydeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjoydeep
Copy link
Copy Markdown

/lgtm /approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, bjoydeep, sahare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants