SPLAT-2592: Removed logic that adds the platform-type labels to nodes for hybrid-env#79296
SPLAT-2592: Removed logic that adds the platform-type labels to nodes for hybrid-env#79296vr4manta wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-2592 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoves the ChangesvSphere Node Labeling Workaround Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-hybrid-env-serial-techpreview-1of2 |
|
@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vr4manta: the repo openshift/release does not contribute to the OpenShift official images, or the base branch is not currently having images promoted |
|
[REHEARSALNOTIFIER]
A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-hybrid-env-serial-techpreview-2of2 |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-e2e-vsphere-ovn-upi-hybrid-env |
|
@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
SPLAT-2592
Changes
Removed platform-type labeling workaround for vSphere hybrid environments
This PR removes a downstream workaround from the vSphere IPI installer step that was adding
node.openshift.io/platform-type=vspherelabels to nodes in hybrid-environment clusters.What changed:
The
label_vsphere_nodes()helper function and its invocation (18 lines) have been removed from the vSphere virtualization installation script (ci-operator/step-registry/ipi/install/vsphere/virt/ipi-install-vsphere-virt-commands.sh). This script is used during CI testing to set up hybrid clusters with vSphere virtual machine nodes.Practical impact:
The vSphere hybrid environment CI tests no longer perform manual node labeling after CSR approval. The script now proceeds directly from node approval to storage and cluster operator configuration. This change suggests that upstream Cloud Controller Manager (CCM) changes have been deployed, making the temporary downstream labeling workaround unnecessary.
Affected infrastructure:
CI configuration for OpenShift clusters using vSphere virtualization with hybrid node types in integration tests.