[WIP] Add jobs for Cilium for OCP 4.22 on Kubevirt and AWS-Private#79291
[WIP] Add jobs for Cilium for OCP 4.22 on Kubevirt and AWS-Private#79291mgencur wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughTwo new periodic HyperShift CI job definitions were added to the OpenShift Hypershift 4.22 periodics file: ChangesHyperShift Periodic Test Definitions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml`:
- Line 198: Replace the deprecated key "minimum_interval: 168h" with a valid
periodic scheduler key by changing it to "interval: 168h" (or use a "cron:"
expression if preferred) inside the __periodics.yaml test entry; ensure the
periodic entry uses only "tests:" entries with either "interval" or "cron"
scheduling and remove any remaining "minimum_interval" occurrences so the test
conforms to the periodics schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dd9e091c-09ca-47cc-8d5f-45e1788407ee
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
| the local DNS endpoint \[Suite:openshift/conformance/parallel\] | ||
| workflow: hypershift-aws-conformance-cilium | ||
| - as: e2e-aws-conformance-cilium-private | ||
| minimum_interval: 168h |
There was a problem hiding this comment.
Use interval or cron for periodic scheduling in this file.
minimum_interval should be replaced with interval (or cron) for this __periodics.yaml test entry.
Suggested fix
- minimum_interval: 168h
+ interval: 168hAs per coding guidelines, "ci-operator/config/**/*__periodics.yaml: Periodic tests in variant periodic configuration files (__periodics.yaml) should contain only tests: entries with interval: or cron: scheduling".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| minimum_interval: 168h | |
| interval: 168h |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml`
at line 198, Replace the deprecated key "minimum_interval: 168h" with a valid
periodic scheduler key by changing it to "interval: 168h" (or use a "cron:"
expression if preferred) inside the __periodics.yaml test entry; ensure the
periodic entry uses only "tests:" entries with either "interval" or "cron"
scheduling and remove any remaining "minimum_interval" occurrences so the test
conforms to the periodics schema.
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-kubevirt-metal-conformance-cilium periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-conformance-cilium-private |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-kubevirt-metal-conformance-cilium periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-conformance-cilium-private |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mgencur: job(s): either don't exist or were not found to be affected, and cannot be rehearsed |
|
@mgencur: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This will probably depend on #78338 to ignore the proper tests and apply the right network policies.
This PR updates OpenShift CI's HyperShift periodic test configuration (ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml) to add two Cilium-focused conformance jobs for OCP 4.22.
Practical impact:
Changes:
e2e-aws-conformance-cilium-private
e2e-kubevirt-metal-conformance-cilium
Other notes: