Skip to content

GCP-297: hypershift: add e2e-v2-gke periodic job for 4.23 and 5.0#79280

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:hypershift-gke-v2-periodic
May 14, 2026
Merged

GCP-297: hypershift: add e2e-v2-gke periodic job for 4.23 and 5.0#79280
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
cblecker:hypershift-gke-v2-periodic

Conversation

@cblecker
Copy link
Copy Markdown
Member

@cblecker cblecker commented May 14, 2026

Summary

  • Adds e2e-v2-gke periodic job (cron 37 9,21 * * *, twice daily) to openshift-hypershift-release-4.23__periodics.yaml and openshift-hypershift-release-5.0__periodics.yaml
  • Uses hypershift-gcp cluster profile, hypershift-gcp-gke-e2e-v2 workflow, with GKE_REGION: us-central1 and GKE_RELEASE_CHANNEL: stable
  • Follows the same pattern as the existing e2e-aks periodic (cron offset by 16 min to avoid overlap)
  • After merge, sippy-config-generator and auto-testgrid-generator will auto-discover the jobs via job-release labels

The corresponding presubmit (e2e-v2-gke) was made required for merge in #78842 (merged May 12). This periodic enables nightly flake detection and Sippy/TestGrid dashboard visibility. Tracked in GCP-297.

Test plan

  • make update succeeds with no unexpected changes
  • Generated job names: periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-gke and periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke
  • Cron 37 9,21 * * * present in generated Prow YAML
  • Only 4 files changed (2 config, 2 generated jobs)

Summary

This PR adds a new periodic CI job, e2e-v2-gke, to the OpenShift Hypershift CI configuration for release variants 4.23 and 5.0.

Changes (practical impact)

  • Adds a periodic ci-operator job entry in the openshift-hypershift release periodic manifests so Hypershift's GKE e2e-v2 tests will run automatically for those release branches.
  • The job runs twice daily at 09:37 and 21:37 UTC (cron: 37 9,21 * * *), offset by 16 minutes from the existing e2e-aks periodic to avoid overlap.
  • Uses the hypershift-gcp cluster profile and the hypershift-gcp-gke-e2e-v2 workflow and sets environment variables GKE_REGION=us-central1 and GKE_RELEASE_CHANNEL=stable.
  • Includes the build-tmpfs capability consistent with other hypershift periodic jobs.
  • After merge, sippy-config-generator and auto-testgrid-generator will pick up the job via job-release labels so results appear in Sippy/TestGrid.

Rationale / Purpose

Enable recurring GKE e2e-v2 runs for Hypershift to detect flakes and provide visibility in Sippy/TestGrid. This complements the presubmit e2e-v2-gke job that was made required in a prior merged PR.

Test plan / Validation

  • make update ran successfully with the expected generated Prow job names:
    • periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-gke
    • periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke
  • The generated Prow YAML contains the cron 37 9,21 * * *.
  • Changes are limited to 4 files (2 config manifests, 2 generated Prow job files).

Metadata / Notes

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5d4c26ee-97ca-4d6b-ae47-1aac42fa352a

📥 Commits

Reviewing files that changed from the base of the PR and between 5b3f170 and 1bb2a47.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml

Walkthrough

Added an e2e-v2-gke periodic hypershift e2e job to the 4.23 and 5.0 release periodic configs. The job targets hypershift-gcp, runs on cron 37 9,21 * * *, sets GKE_REGION and GKE_RELEASE_CHANNEL, requires build-tmpfs, and uses hypershift-gcp-gke-e2e-v2 workflow.

Changes

Periodic GKE e2e Test Addition

Layer / File(s) Summary
Periodic job entry (both releases)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
Added tests[].as: e2e-v2-gke periodic job with cron: "37 9,21 * * *", cluster_profile: hypershift-gcp, capability build-tmpfs, env vars GKE_REGION: us-central1 and GKE_RELEASE_CHANNEL: stable, and workflow: hypershift-gcp-gke-e2e-v2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a new e2e-v2-gke periodic job for hypershift across two release versions (4.23 and 5.0).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI configuration only, not Ginkgo test code. No test names are defined or modified. Configuration is static with no dynamic values.
Test Structure And Quality ✅ Passed This PR modifies only YAML configuration files to add periodic job definitions. No Ginkgo test code is included, so the test code quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR adds CI configuration only (YAML files), not Ginkgo e2e test code. The custom check targets new test code additions, not CI configuration. Not applicable to this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds a new periodic CI job configuration that schedules existing tests, not new Ginkgo e2e tests. Changes are YAML CI configuration files only.
Topology-Aware Scheduling Compatibility ✅ Passed This PR adds CI test job configurations only. The custom check for topology-aware scheduling applies to deployment manifests and operator code, not CI operator configuration files.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI/CD configuration files with no Go code changes. OTE Binary Stdout Contract check applies only to Go source code; not applicable here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e test code is added in this PR—only YAML CI job configuration. The check targets PRs that add new test code, not CI configuration files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Nirshal and muraee May 14, 2026 01:20
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@cblecker cblecker changed the title hypershift: add e2e-v2-gke periodic job for 4.23 and 5.0 GCP-297: hypershift: add e2e-v2-gke periodic job for 4.23 and 5.0 May 14, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 14, 2026

@cblecker: This pull request references GCP-297 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds e2e-v2-gke periodic job (cron 37 9,21 * * *, twice daily) to openshift-hypershift-release-4.23__periodics.yaml and openshift-hypershift-release-5.0__periodics.yaml
  • Uses hypershift-gcp cluster profile, hypershift-gcp-gke-e2e-v2 workflow, with GKE_REGION: us-central1 and GKE_RELEASE_CHANNEL: stable
  • Follows the same pattern as the existing e2e-aks periodic (cron offset by 16 min to avoid overlap)
  • After merge, sippy-config-generator and auto-testgrid-generator will auto-discover the jobs via job-release labels

The corresponding presubmit (e2e-v2-gke) was made required for merge in #78842 (merged May 12). This periodic enables nightly flake detection and Sippy/TestGrid dashboard visibility. Tracked in GCP-297.

Test plan

  • make update succeeds with no unexpected changes
  • Generated job names: periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-gke and periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke
  • Cron 37 9,21 * * * present in generated Prow YAML
  • Only 4 files changed (2 config, 2 generated jobs)

Summary

This PR adds a new periodic test job e2e-v2-gke to the OpenShift Hypershift project's CI configuration. The job is configured for both release variants 4.23 and 5.0.

Changes

The new periodic job:

  • Runs twice daily on a cron schedule of 37 9,21 * * * (9:37 AM and 9:37 PM UTC)
  • Uses the hypershift-gcp cluster profile and hypershift-gcp-gke-e2e-v2 workflow
  • Configures Google Cloud environment with GKE_REGION: us-central1 and GKE_RELEASE_CHANNEL: stable
  • The cron schedule is offset 16 minutes from the similar e2e-aks job to avoid overlap

Purpose

The job is being added to enable nightly flake detection for Hypershift GKE (Google Kubernetes Engine) tests. Once merged, the sippy-config-generator and auto-testgrid-generator tools will automatically discover and monitor these periodic jobs through job-release labels, providing visibility in Sippy and TestGrid dashboards. This complements the related required presubmit job that was made mandatory in a prior merged PR, ensuring comprehensive test coverage and visibility across CI/CD tooling.

Files Modified

Configuration files for the release-4.23 and release-5.0 variants of the openshift-hypershift project (2 config files, with 2 additional generated Prow job manifest files).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cblecker
Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2026
Adds a twice-daily cron periodic (37 9,21 * * *) for the GKE v2 e2e
test to the release-4.23 and release-5.0 periodic variants. The
corresponding presubmit (e2e-v2-gke) was made required for merge in
openshift#78842; this periodic enables nightly flake detection and Sippy/TestGrid
dashboard visibility once auto-generators pick it up post-merge.

Assisted-by: Claude:claude-sonnet-4-6[1m]
@cblecker cblecker force-pushed the hypershift-gke-v2-periodic branch from 5b3f170 to 1bb2a47 Compare May 14, 2026 15:31
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@cblecker: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-gke N/A periodic Periodic changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@cristianoveiga
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cristianoveiga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 82325a3 into openshift:main May 14, 2026
18 checks passed
@cblecker cblecker deleted the hypershift-gke-v2-periodic branch May 14, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants