GCP-297: hypershift: add e2e-v2-gke periodic job for 4.23 and 5.0#79280
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded an ChangesPeriodic GKE e2e Test Addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@cblecker: This pull request references GCP-297 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse auto-ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Adds a twice-daily cron periodic (37 9,21 * * *) for the GKE v2 e2e test to the release-4.23 and release-5.0 periodic variants. The corresponding presubmit (e2e-v2-gke) was made required for merge in openshift#78842; this periodic enables nightly flake detection and Sippy/TestGrid dashboard visibility once auto-generators pick it up post-merge. Assisted-by: Claude:claude-sonnet-4-6[1m]
5b3f170 to
1bb2a47
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, cristianoveiga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
e2e-v2-gkeperiodic job (cron37 9,21 * * *, twice daily) toopenshift-hypershift-release-4.23__periodics.yamlandopenshift-hypershift-release-5.0__periodics.yamlhypershift-gcpcluster profile,hypershift-gcp-gke-e2e-v2workflow, withGKE_REGION: us-central1andGKE_RELEASE_CHANNEL: stablee2e-aksperiodic (cron offset by 16 min to avoid overlap)sippy-config-generatorandauto-testgrid-generatorwill auto-discover the jobs viajob-releaselabelsThe corresponding presubmit (
e2e-v2-gke) was made required for merge in #78842 (merged May 12). This periodic enables nightly flake detection and Sippy/TestGrid dashboard visibility. Tracked in GCP-297.Test plan
make updatesucceeds with no unexpected changesperiodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-gkeandperiodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-gke37 9,21 * * *present in generated Prow YAMLSummary
This PR adds a new periodic CI job, e2e-v2-gke, to the OpenShift Hypershift CI configuration for release variants 4.23 and 5.0.
Changes (practical impact)
37 9,21 * * *), offset by 16 minutes from the existing e2e-aks periodic to avoid overlap.hypershift-gcpcluster profile and thehypershift-gcp-gke-e2e-v2workflow and sets environment variablesGKE_REGION=us-central1andGKE_RELEASE_CHANNEL=stable.build-tmpfscapability consistent with other hypershift periodic jobs.Rationale / Purpose
Enable recurring GKE e2e-v2 runs for Hypershift to detect flakes and provide visibility in Sippy/TestGrid. This complements the presubmit e2e-v2-gke job that was made required in a prior merged PR.
Test plan / Validation
make updateran successfully with the expected generated Prow job names:37 9,21 * * *.Metadata / Notes