Skip to content

WIP: fix: resolve lint markdown job failure#79270

Closed
eggfoobar wants to merge 1 commit into
openshift:mainfrom
eggfoobar:fix-clone-on-edge-tooling-presubmits
Closed

WIP: fix: resolve lint markdown job failure#79270
eggfoobar wants to merge 1 commit into
openshift:mainfrom
eggfoobar:fix-clone-on-edge-tooling-presubmits

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented May 13, 2026

Summary by CodeRabbit

  • Chore

    • CI presubmit now runs additional workspace diagnostics (prints working directory, lists files, shows Makefile) before invoking the markdown lint step.
    • The markdown lint job now uses a promoted markdownlint base image alias instead of the previous direct container reference.
  • Bug Fix

    • Removed an earlier container clone setting from the markdown lint job configuration.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 58b83736-7daf-448a-8018-4626841742f6

📥 Commits

Reviewing files that changed from the base of the PR and between 7573ae3 and e1f166e.

📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml

Walkthrough

Replaces the markdownlint job's container with a promoted base image promotedmarkdownlint (name: markdownlint-cli2, namespace: ci, tag: latest), removes the prior container.clone: true setting, and expands commands to pwd && ls -la && cat Makefile && make lint-markdown.

Changes

Markdownlint CI job and promotion

Layer / File(s) Summary
Promoted container entry
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
Adds a base_images promotion entry promotedmarkdownlint pointing to markdownlint-cli2 in namespace ci with tag latest.
Job container wiring and commands
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
Updates the markdownlint job to use container.from: promotedmarkdownlint, removes container.clone: true, and replaces commands: make lint-markdown with pwd && ls -la && cat Makefile && make lint-markdown.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'fix: resolve lint markdown job failure' which directly relates to the markdownlint job changes in the PR, but the 'WIP:' prefix and 'fix:' conventional commit prefix add unnecessary verbosity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only a YAML CI configuration file, not Ginkgo tests. Custom check for stable Ginkgo test names is not applicable.
Test Structure And Quality ✅ Passed The PR does not contain Ginkgo test code. Modified test files use standard Go testing (testing.T), not Ginkgo. The check for Ginkgo test structure is not applicable.
Microshift Test Compatibility ✅ Passed PR modifies only CI operator configuration for markdownlint/shellcheck jobs. No Ginkgo e2e tests are added. MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add or modify any Ginkgo e2e tests. It only changes CI operator configuration for a markdownlint job. The SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies only a CI operator configuration file with no deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed The PR only modifies a CI operator configuration file (YAML), not OTE binary source code. The custom check applies to process-level code in OTE binaries, which is not present here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests are added or modified. PR only modifies CI config file for markdownlint job. Check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and suleymanakbas91 May 13, 2026 19:17
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@eggfoobar eggfoobar force-pushed the fix-clone-on-edge-tooling-presubmits branch from 2ca4ad4 to 35a97f2 Compare May 13, 2026 19:50
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA 3142f6aa8c07f0b26d1698cfb34d757846670459: error checking out "3142f6aa8c07f0b26d1698cfb34d757846670459": exit status 128 fatal: unable to read tree (3142f6aa8c07f0b26d1698cfb34d757846670459)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar eggfoobar force-pushed the fix-clone-on-edge-tooling-presubmits branch from 35a97f2 to 6701e7e Compare May 13, 2026 20:19
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to submit all rehearsal jobs

If the problem persists, please contact Test Platform.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@eggfoobar eggfoobar force-pushed the fix-clone-on-edge-tooling-presubmits branch from 6701e7e to 7573ae3 Compare May 13, 2026 21:08
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the fix-clone-on-edge-tooling-presubmits branch from 7573ae3 to e1f166e Compare May 13, 2026 21:24
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-edge-tooling-main-images openshift-eng/edge-tooling presubmit Ci-operator config changed
pull-ci-openshift-eng-edge-tooling-main-markdownlint openshift-eng/edge-tooling presubmit Ci-operator config changed
pull-ci-openshift-eng-edge-tooling-main-shellcheck openshift-eng/edge-tooling presubmit Ci-operator config changed
periodic-ci-openshift-eng-edge-tooling-main-ocp-ci-monitor N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-edge-tooling-main-pr-notifier N/A periodic Ci-operator config changed
periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prucek
Copy link
Copy Markdown
Member

Prucek commented May 14, 2026

/pj-rehearse pull-ci-openshift-eng-edge-tooling-main-markdownlint pull-ci-openshift-eng-edge-tooling-main-shellcheck

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@Prucek: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

No longer needed, fix was implemented in ci tooling openshift/ci-tools#5179

@eggfoobar eggfoobar closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants