Skip to content

Add optional disconnected agent conformance presubmit for hypershift main#79267

Open
bryan-cox wants to merge 2 commits into
openshift:mainfrom
bryan-cox:worktree-add-disconnected-presubmit
Open

Add optional disconnected agent conformance presubmit for hypershift main#79267
bryan-cox wants to merge 2 commits into
openshift:mainfrom
bryan-cox:worktree-add-disconnected-presubmit

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented May 13, 2026

Summary

  • Adds e2e-agent-disconnected-ovn-ipv6-metal-conformance as an optional presubmit on the hypershift main branch
  • This job already runs as a periodic on release branches (4.16–4.22) but was not triggerable on PRs
  • Allows PR authors to test disconnected ICSP/IDMS conformance via /test e2e-agent-disconnected-ovn-ipv6-metal-conformance

Test plan

  • Verify CI config validation passes
  • Trigger the job on a hypershift PR with /test e2e-agent-disconnected-ovn-ipv6-metal-conformance

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Chores
    • Added comprehensive CI conformance testing for IPv6 networking with OVN Kubernetes on bare metal deployments to strengthen quality assurance and testing coverage.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 68c008b6-5ecc-4a51-86c2-35be370e6f24

📥 Commits

Reviewing files that changed from the base of the PR and between 910a89c and 8eb70d6.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

Walkthrough

A new optional CI test job e2e-agent-disconnected-ovn-ipv6-metal-conformance was added to the HyperShift CI configuration. The test runs IPv6-enabled agent-disconnected conformance testing with OVN Kubernetes networking on Equinix infrastructure, specifying LVM operator channel stable-4.23 and MCE version 2.17.

Changes

IPv6 Agent-Disconnected OVN Conformance Test Job

Layer / File(s) Summary
New CI test job configuration
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
Added optional test job e2e-agent-disconnected-ovn-ipv6-metal-conformance with environment variables for IPv6 stack, OVN Kubernetes networking, LVM operator channel stable-4.23, MCE version 2.17, and Equinix cluster profile using the hypershift-mce-agent-disconnected-conformance workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an optional disconnected agent conformance presubmit job for hypershift main branch, matching the file changes and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check not applicable. This PR modifies CI configuration files, not Ginkgo test source code. The check is designed for test code with Ginkgo patterns, which are not present here.
Test Structure And Quality ✅ Passed Custom check not applicable. PR only modifies CI configuration (YAML), not Ginkgo test code. No test code quality review needed.
Microshift Test Compatibility ✅ Passed PR adds CI configuration metadata only, not new Ginkgo test code. The check applies only to new test implementations, which are not present here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The change only adds a CI job configuration referencing an existing workflow. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI test configuration, not deployment manifests or operator code. No scheduling constraints or topology assumptions introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI config file. OTE Binary Stdout Contract check applies to Go test code, not CI configuration files. Check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI job configuration. No new Ginkgo e2e tests defined. Custom check for IPv6/disconnected compatibility not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from clebs and csrwng May 13, 2026 18:39
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2026
bryan-cox and others added 2 commits May 13, 2026 15:19
…main

Adds e2e-agent-disconnected-ovn-ipv6-metal-conformance as an optional
presubmit on the hypershift main branch, allowing PR authors to trigger
disconnected ICSP/IDMS conformance testing with /test.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bryan-cox bryan-cox force-pushed the worktree-add-disconnected-presubmit branch from 8eb70d6 to c29aa56 Compare May 13, 2026 19:21
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@bryan-cox: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-agent-disconnected-ovn-ipv6-metal-conformance openshift/hypershift presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented May 14, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bryan-cox
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-agent-disconnected-ovn-ipv6-metal-conformance

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants