Skip to content

AUTOSCALE-681: Add AutoNode multi-arch periodic to HCP#79262

Draft
maxcao13 wants to merge 1 commit into
openshift:mainfrom
maxcao13:hcp-autonode-fix
Draft

AUTOSCALE-681: Add AutoNode multi-arch periodic to HCP#79262
maxcao13 wants to merge 1 commit into
openshift:mainfrom
maxcao13:hcp-autonode-fix

Conversation

@maxcao13
Copy link
Copy Markdown
Member

@maxcao13 maxcao13 commented May 13, 2026

Also adjust autonode presubmit to include all Karpenter tests, multi-arch, remove TP.

Overview

This PR adds multi-arch support for AutoNode/Karpenter testing in the OpenShift hypershift repository's CI infrastructure, and establishes periodic jobs to validate AutoNode functionality across multiple OpenShift release branches.

Changes to Hypershift CI Configuration

Multi-arch release definitions (openshift-hypershift-main.yaml):

  • Adds multi-initial and multi-latest release image candidates targeting OCP 5.0 with multi-architecture support
  • These enable CI jobs to test against multi-arch release images rather than single-architecture variants

Updated e2e-aws-autonode presubmit test (openshift-hypershift-main.yaml):

  • Converts the test to use multi-arch release images (OCP_IMAGE_LATEST and OCP_IMAGE_PREVIOUS)
  • Enables multi-architecture testing via AWS_MULTI_ARCH: "true"
  • Updates test filtering from explicit pattern with tail anchor to ^TestKarpenter pattern
  • Removes tech-preview upgrade restriction (TECH_PREVIEW_NO_UPGRADE)

New periodic test jobs:
Adds e2e-aws-autonode periodic test jobs running every 12 hours across three release branches:

  • openshift-hypershift-release-4.22__periodics.yaml
  • openshift-hypershift-release-4.23__periodics.yaml
  • openshift-hypershift-release-5.0__periodics.yaml

Each periodic job uses the hypershift AWS cluster profile, runs full Karpenter test suite (^TestKarpenter), and validates multi-arch AutoNode functionality with hypershift feature flags enabled.

Impact

Enables continuous multi-architecture testing of AutoNode and Karpenter functionality in hypershift across recent and future OpenShift release branches, improving confidence in AutoNode compatibility across diverse architectures.

Also adjust autonode presubmit to include all Karpenter tests, multi-arch, remove TP.

Signed-off-by: Max Cao <macao@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2026

@maxcao13: This pull request references AUTOSCALE-681 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Also adjust autonode presubmit to include all Karpenter tests, multi-arch, remove TP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maxcao13 maxcao13 changed the title AUTOSCALE-681: Add AutoNode multi-arch periodic AUTOSCALE-681: Add AutoNode multi-arch periodic to HCP May 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a776e472-b33a-4598-9a46-580ea81ed443

📥 Commits

Reviewing files that changed from the base of the PR and between aad6e7d and e62bf6a.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml

Walkthrough

The PR enables multi-architecture (AMD64 + ARM64) AWS autonode testing for HyperShift by introducing multi-arch release definitions in the main configuration and adding periodic test jobs for three OpenShift releases (4.22, 4.23, 5.0) that consume these releases.

Changes

Multi-Arch AWS Autonode Testing

Layer / File(s) Summary
Multi-arch release definitions
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
Two new release entries multi-initial and multi-latest are defined with architecture: multi, version: "5.0", and stream: nightly to provide multi-arch OCP images for testing.
Updated main test job for multi-arch
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
The e2e-aws-autonode test job is reconfigured to use OCP_IMAGE_LATEST: release:multi-latest and OCP_IMAGE_PREVIOUS: release:multi-initial, sets AWS_MULTI_ARCH: "true", updates CI_TESTS_RUN to match ^TestKarpenter, and removes TECH_PREVIEW_NO_UPGRADE.
Periodic test jobs across releases
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
Three new periodic test entries named e2e-aws-autonode are added with 0 */12 * * * cron schedule, hypershift-aws cluster profile, dependencies on the multi-arch releases, environment variables for multi-arch AWS and Karpenter testing, and hypershift-aws-e2e-nested workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a multi-arch periodic job for AutoNode testing in HCP, which aligns with the changeset's core objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI operator configuration YAML files, not test code. Custom check applies to Ginkgo test names in test files, which are absent here. Not applicable.
Test Structure And Quality ✅ Passed PR modifies only CI configuration YAML files, not Ginkgo test code. Custom check for Ginkgo test quality is not applicable to this PR since no test implementations are modified.
Microshift Test Compatibility ✅ Passed PR modifies only CI configuration YAML files in openshift/release. No new Ginkgo test code (It(), Describe(), etc.) is added. Check targets new test definitions, which don't exist here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies only YAML CI configuration files. No new Ginkgo e2e test code (It(), Describe(), etc.) is added. The check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies CI test configuration files, not deployment manifests or operator code. Check is not applicable to test job definitions.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI/CD configuration files. No executable code is changed. The OTE Binary Stdout Contract check applies to executable binaries and process-level code, which is absent here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds CI configuration for multi-arch periodic e2e tests using existing Karpenter tests. It does not add new Ginkgo test code, only YAML CI job definitions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maxcao13
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-address-review-comments openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-agentic-qe-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aks-4-22 openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aks-override openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-4-22 openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-autonode openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-external-oidc-techpreview openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-metrics openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-minimal openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-override openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-techpreview openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-aks-external-oidc-techpreview openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-kubevirt-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-self-managed openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-v2-self-managed openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-gke openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-aws openshift/hypershift presubmit Ci-operator config changed

A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maxcao13
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws pull-ci-openshift-hypershift-main-e2e-aws-autonode periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-autonode periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-autonode

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@maxcao13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-autonode e62bf6a link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aws-autonode
ci/rehearse/openshift/hypershift/main/e2e-aws-autonode e62bf6a link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-autonode
ci/rehearse/periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-autonode e62bf6a link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-autonode

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxcao13
Copy link
Copy Markdown
Member Author

Well seems like the arm test is failing, so gonna investigate that.

@maxcao13
Copy link
Copy Markdown
Member Author

Seems like quay.io/openshift/origin-pod only has an amd64 manifest, so it can't pull it. I'm not sure why I thought this was working before. I will put in an hcp PR to select a different image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants