MCO-2257: use RHEL10 by default in 5.0#79260
Draft
cheesesashimi wants to merge 1 commit into
Draft
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
@cheesesashimi: This pull request references MCO-2257 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
WalkthroughThis PR migrates the machine-config-operator CI configurations across main and release branches (4.23, 5.0, 5.1) from RHEL 7 to RHEL 9 and RHEL 10 base image builds. Dockerfile paths in periodic test configurations are also updated to use RHEL 10 instead of RHEL 7. ChangesRHEL 7 to RHEL 9/10 Image Build Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__arm64-periodics.yaml`:
- Line 18: The periodic for release-4.23 incorrectly uses dockerfile_path:
Dockerfile.rhel10; change the value back to Dockerfile.rhel9 so the ARM64
release-4.23 periodic matches main-config intent and other periodics. Update the
dockerfile_path entry in the release-4.23 __arm64-periodics.yaml stanza from
Dockerfile.rhel10 to Dockerfile.rhel9, and verify the rest of the copied
sections mirror the main config for release-4.23.
In
`@ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml`:
- Line 18: The periodic job for machine-config-operator in release-4.23 is using
the wrong RHEL base; update the dockerfile_path from "Dockerfile.rhel10" to
"Dockerfile.rhel9" so the release-4.23 periodics default to RHEL9 as intended;
locate the dockerfile_path entry in the machine-config-operator periodic config
(the block that sets dockerfile_path: Dockerfile.rhel10 for release-4.23) and
change it to Dockerfile.rhel9, ensuring the rest of the job metadata for
machine-config-operator remains unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6f9d7f72-bc4d-47ef-8c2e-af4ff0d9f21d
⛔ Files ignored due to path filters (10)
ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (8)
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__arm64-periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__arm64-periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yamlci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1.yaml
cheesesashimi
force-pushed
the
zzlotnik/rhel10-by-default
branch
from
70399b0 to
5e3b868
Compare
Contributor
|
[REHEARSALNOTIFIER]
A total of 349 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
cheesesashimi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By separating the MCO images into RHEL9 and RHEL10 configs, we're able to specify which release should get which RHEL version installed by default. The changes in this PR will have the following effects:
mainand5.0will begin using RHEL10 by default, even though we are still technically in 4.23.release-4.23will continue to use RHEL9 by default for presubmits. This will apply to any periodics as well which specifically targetrelease-4.23.