Skip to content

Various improvements to Claude payload step#75810

Merged
openshift-merge-bot[bot] merged 10 commits intoopenshift:mainfrom
stbenjam:stuck-claude
Mar 6, 2026
Merged

Various improvements to Claude payload step#75810
openshift-merge-bot[bot] merged 10 commits intoopenshift:mainfrom
stbenjam:stuck-claude

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 6, 2026

  • Handle stuck Claude
  • Generate JUnits for metrics (durations, timeouts, etc)
  • Tone down Slack emojis

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@openshift-ci openshift-ci bot requested review from neisw and smg247 March 6, 2026 13:10
stbenjam and others added 8 commits March 6, 2026 08:28
@stbenjam
Nudge Claude if he gets stuck
d5a238b 
Occassionally, I've seen Claude get stick and hit the timeout. This
detects the timeout and nudges him to still produce a final report.
@stbenjam @claude
Add JUnit XML reporting for Claude timeout tracking
e2d266f 
Emit a junit_claude-ci.xml artifact so Sippy/testgrid can track
Claude payload analysis timeouts. Three scenarios:
- No timeout: 1 passing test
- Timeout + nudge recovers: 1 fail + 1 pass (flake)
- Timeout + nudge fails: 2 failures

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stbenjam @claude
Add phase duration tracking to JUnit XML
483935a 
Record wall-clock time for each phase (wait for blocking jobs,
analysis, recovery nudge) using the JUnit time attribute on
testcases and the testsuite. This lets Sippy/testgrid track
how long each phase takes over time.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stbenjam
Add rehearseable job
852ff4b
@stbenjam @claude
Copy report artifacts before JUnit generation
41e9204 
Move HTML report and autodl JSON copies earlier so they are
rescued even if JUnit generation fails unexpectedly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@stbenjam
Tone down emojis
2b3bc20
@stbenjam
Fix config ordering
38686a3
@stbenjam
make jobs
0473f41
@stbenjam
Copy link
Member Author

stbenjam commented Mar 6, 2026

/pj-rehearse periodic-ci-openshift-release-main-payload-analysis-test-claude-payload-analysis-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2026

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 6, 2026

[REHEARSALNOTIFIER]
@stbenjam: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2026
@stbenjam
Copy link
Member Author

stbenjam commented Mar 6, 2026

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sosiouxme
sosiouxme approved these changes Mar 6, 2026
View reviewed changes
Copy link
Member

@sosiouxme sosiouxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f259262 into openshift:main Mar 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neisw neisw Awaiting requested review from neisw

@smg247 smg247 Awaiting requested review from smg247

1 more reviewer

@sosiouxme sosiouxme sosiouxme approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sosiouxme sosiouxme

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stbenjam @openshift-ci-robot @sosiouxme