HYPERFLEET-695 - ci: configure Slack notifications for HyperFleet E2E periodic jobs#75785
HYPERFLEET-695 - ci: configure Slack notifications for HyperFleet E2E periodic jobs#75785tzhou5 wants to merge 3 commits intoopenshift:mainfrom
Conversation
| @@ -0,0 +1,9 @@ | |||
| slack_reporter: | |||
There was a problem hiding this comment.
As we have not maintained the deployment from the job,I think we can not enable it for this job to avoid noise message.WDYT?
There was a problem hiding this comment.
Good point — the hyperfleet-chart deployment job is not an E2E test, so I've removed its Slack config. The PR now only covers the hyperfleet-e2e periodic job.
|
Is it possible to test the workflow before the PR is merged to check if the message is sent to slack channel? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tzhou5 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yingzhanredhat Regarding pre-merge testing — I haven't found a way to test the Slack reporter before merge. pj-rehearse doesn't cover reporter functionality. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@tzhou5: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| - success | ||
| - failure | ||
| - error | ||
| report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>' |
There was a problem hiding this comment.
Priority: Pattern
The template is missing a job history link that most other teams include. For
a nightly periodic job, the history view is arguably more important than the
single-run logs — it tells you whether the failure is a new regression or a
known flaky test.
Other teams like openshift/installer include this. Suggested template:
| report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>' | |
| report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> · <https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/{{.Spec.Job}}|View history>' |
No description provided.