Skip to content

HYPERFLEET-695 - ci: configure Slack notifications for HyperFleet E2E periodic jobs#75785

Open
tzhou5 wants to merge 3 commits intoopenshift:mainfrom
tzhou5:hyperfleet-695-slack-reporter
Open

HYPERFLEET-695 - ci: configure Slack notifications for HyperFleet E2E periodic jobs#75785
tzhou5 wants to merge 3 commits intoopenshift:mainfrom
tzhou5:hyperfleet-695-slack-reporter

Conversation

@tzhou5
Copy link
Contributor

@tzhou5 tzhou5 commented Mar 6, 2026

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@openshift-ci openshift-ci bot requested review from vkareh and xueli181114 March 6, 2026 02:40
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2026
@@ -0,0 +1,9 @@
slack_reporter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have not maintained the deployment from the job,I think we can not enable it for this job to avoid noise message.WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point — the hyperfleet-chart deployment job is not an E2E test, so I've removed its Slack config. The PR now only covers the hyperfleet-e2e periodic job.

@yingzhanredhat
Copy link
Contributor

Is it possible to test the workflow before the PR is merged to check if the message is sent to slack channel?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tzhou5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tzhou5
Copy link
Contributor Author

tzhou5 commented Mar 6, 2026

@yingzhanredhat Regarding pre-merge testing — I haven't found a way to test the Slack reporter before merge. pj-rehearse doesn't cover reporter functionality.
Besides, the notifications go to a new dedicated channel (#hyperfleet-e2e-status), so the beginning noisy messages won't affecting others. We can verify the notifications are working correctly after merge before inviting the team to the channel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tzhou5: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@tzhou5: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- success
- failure
- error
report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority: Pattern

The template is missing a job history link that most other teams include. For
a nightly periodic job, the history view is arguably more important than the
single-run logs — it tells you whether the failure is a new regression or a
known flaky test.

Other teams like openshift/installer include this. Suggested template:

Suggested change
report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs>'
report_template: '{{if eq .Status.State "success"}}:white_check_mark:{{else}}:x:{{end}} *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> · <https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/{{.Spec.Job}}|View history>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants