Skip to content

kubernetes-nmstate: add monitor tests to e2e-operator-ovn-ipv4#75592

Open
qinqon wants to merge 1 commit intoopenshift:mainfrom
qinqon:kubernetes-nmstate-monitor-tests
Open

kubernetes-nmstate: add monitor tests to e2e-operator-ovn-ipv4#75592
qinqon wants to merge 1 commit intoopenshift:mainfrom
qinqon:kubernetes-nmstate-monitor-tests

Conversation

@qinqon
Copy link
Contributor

@qinqon qinqon commented Mar 3, 2026

Add openshift-tests run-monitor to the e2e-operator-ovn-ipv4 job for
openshift/kubernetes-nmstate to catch cluster state violations (e.g. pods
using the default service account in openshift-* namespaces).

Creates a reusable openshift-e2e-monitor-tests step that runs
openshift-tests run-monitor for a configurable duration and fails the
job if any monitor tests detect issues. Also enables the
observers-resource-watch observer for artifact collection.

/cc @openshift/openshift-team-nmstate

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@qinqon: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-nmstate.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Add openshift-tests run-monitor to the e2e-operator-ovn-ipv4 job for
openshift/kubernetes-nmstate to catch cluster state violations (e.g. pods
using the default service account in openshift-* namespaces).

Creates a reusable openshift-e2e-monitor-tests step that runs
openshift-tests run-monitor for a configurable duration and fails the
job if any monitor tests detect issues. Also enables the
observers-resource-watch observer for artifact collection.

/cc @openshift/openshift-team-nmstate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qinqon
Copy link
Contributor Author

qinqon commented Mar 3, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qinqon qinqon force-pushed the kubernetes-nmstate-monitor-tests branch from f474629 to 8d23d30 Compare March 3, 2026 09:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@qinqon
Copy link
Contributor Author

qinqon commented Mar 3, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qinqon qinqon force-pushed the kubernetes-nmstate-monitor-tests branch from 8d23d30 to c311572 Compare March 3, 2026 10:13
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 3, 2026
@qinqon qinqon force-pushed the kubernetes-nmstate-monitor-tests branch from c311572 to 10a768d Compare March 3, 2026 10:35
@qinqon
Copy link
Contributor Author

qinqon commented Mar 3, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add openshift-tests run-monitor step and observers-resource-watch
observer to the e2e-operator-ovn-ipv4 job for openshift/kubernetes-nmstate.
This catches cluster state violations such as pods using the default
service account in openshift-* namespaces.

Creates a reusable openshift-e2e-monitor-tests step that runs
openshift-tests run-monitor for a configurable duration and fails
the job if any monitor tests detect issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the kubernetes-nmstate-monitor-tests branch from 10a768d to 3461652 Compare March 3, 2026 11:21
@qinqon
Copy link
Contributor Author

qinqon commented Mar 3, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@qinqon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@qinqon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-nmstate-main-e2e-operator-ovn-ipv4 openshift/kubernetes-nmstate presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • rhrazdil
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • ci-operator/step-registry/kubernetes-nmstate/e2e/monitor-tests/OWNERS

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/kubernetes-nmstate/main/e2e-operator-ovn-ipv4 3461652 link unknown /pj-rehearse pull-ci-openshift-kubernetes-nmstate-main-e2e-operator-ovn-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants