[WIP]CNTRLPLANE-752: Add manual verification wait step for NodePool API testing

[wangke19]

Summary

This PR adds a manual verification wait step to the HyperShift AWS e2e testing workflow for release-4.21, enabling manual inspection of NodePool API schema during CI runs.

Changes

Infrastructure Code (Commit 1)

• New Step: hypershift-aws-wait-for-manual-verification

  • Pauses test execution for 1 hour (configurable via WAIT_DURATION)
  • Displays helpful commands for inspecting NodePools
  • Shows current NodePool status

• New Workflow: hypershift-aws-e2e-manual-verify

  • Based on hypershift-aws-e2e-external
  • Includes wait step between cluster setup and e2e tests

• New Test Configuration: e2e-aws-manual-verify in release-4.21

  • Optional test (always_run: false)
  • Can be triggered with /test e2e-aws-manual-verify

Generated Artifacts (Commit 2)

• Auto-generated presubmit job definition

Purpose

This feature supports manual verification of:

• NodePool API schema fields (e.g., imageType from CNTRLPLANE-408)
• NodePool configurations before automated tests run
• Debugging of NodePool creation issues

Usage

The wait step can be triggered on any PR in the hypershift release-4.21 branch:

/test e2e-aws-manual-verify

The step will pause for 1 hour (adjustable via WAIT_DURATION env var) displaying commands to inspect NodePools.

Related Issues

• OCPSTRAT-1949: Windows LI AMI Support in ROSA-HCP
• CNTRLPLANE-408: Add imageType field to NodePool API

Commit Structure

Following the openshift/release two-commit pattern:

1. Commit 1: Infrastructure code changes (step-registry, config, workflow)
2. Commit 2: Generated artifacts (presubmits.yaml via make jobs)

/assign @csrwng @sjenning
/cc @enxebre @imain

[openshift-ci]

@wangke19: GitHub didn't allow me to request PR reviews from the following users: imain.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Summary

This PR adds a manual verification wait step to the HyperShift AWS e2e testing workflow for release-4.21, enabling manual inspection of NodePool API schema during CI runs.

Changes

Infrastructure Code (Commit 1)

• New Step: hypershift-aws-wait-for-manual-verification

• Pauses test execution for 1 hour (configurable via WAIT_DURATION)

• Displays helpful commands for inspecting NodePools

• Shows current NodePool status

• New Workflow: hypershift-aws-e2e-manual-verify

• Based on hypershift-aws-e2e-external

• Includes wait step between cluster setup and e2e tests

• New Test Configuration: e2e-aws-manual-verify in release-4.21

• Optional test (always_run: false)

• Can be triggered with /test e2e-aws-manual-verify

Generated Artifacts (Commit 2)

• Auto-generated presubmit job definition

Purpose

This feature supports manual verification of:

• NodePool API schema fields (e.g., imageType from CNTRLPLANE-408)
• NodePool configurations before automated tests run
• Debugging of NodePool creation issues

Usage

The wait step can be triggered on any PR in the hypershift release-4.21 branch:

/test e2e-aws-manual-verify

The step will pause for 1 hour (adjustable via WAIT_DURATION env var) displaying commands to inspect NodePools.

Related Issues

• OCPSTRAT-1949: Windows LI AMI Support in ROSA-HCP
• CNTRLPLANE-408: Add imageType field to NodePool API

Commit Structure

Following the openshift/release two-commit pattern:

1. Commit 1: Infrastructure code changes (step-registry, config, workflow)
2. Commit 2: Generated artifacts (presubmits.yaml via make jobs)

/assign @csrwng @sjenning
/cc @enxebre @imain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangke19
Once this PR has been reviewed and has the lgtm label, please ask for approval from csrwng. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS
• ci-operator/jobs/openshift/hypershift/OWNERS
• ci-operator/step-registry/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wangke19]

/pj-rehearse pull-ci-openshift-hypershift-release-4.21-e2e-aws-manual-verify

[openshift-ci-robot]

@wangke19: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@wangke19: This pull request references CNTRLPLANE-752 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR adds a manual verification wait step to the HyperShift AWS e2e testing workflow for release-4.21, enabling manual inspection of NodePool API schema during CI runs.

Changes

Infrastructure Code (Commit 1)

• New Step: hypershift-aws-wait-for-manual-verification

• Pauses test execution for 1 hour (configurable via WAIT_DURATION)

• Displays helpful commands for inspecting NodePools

• Shows current NodePool status

• New Workflow: hypershift-aws-e2e-manual-verify

• Based on hypershift-aws-e2e-external

• Includes wait step between cluster setup and e2e tests

• New Test Configuration: e2e-aws-manual-verify in release-4.21

• Optional test (always_run: false)

• Can be triggered with /test e2e-aws-manual-verify

Generated Artifacts (Commit 2)

• Auto-generated presubmit job definition

Purpose

This feature supports manual verification of:

• NodePool API schema fields (e.g., imageType from CNTRLPLANE-408)
• NodePool configurations before automated tests run
• Debugging of NodePool creation issues

Usage

The wait step can be triggered on any PR in the hypershift release-4.21 branch:

/test e2e-aws-manual-verify

The step will pause for 1 hour (adjustable via WAIT_DURATION env var) displaying commands to inspect NodePools.

Related Issues

• OCPSTRAT-1949: Windows LI AMI Support in ROSA-HCP
• CNTRLPLANE-408: Add imageType field to NodePool API

Commit Structure

Following the openshift/release two-commit pattern:

1. Commit 1: Infrastructure code changes (step-registry, config, workflow)
2. Commit 2: Generated artifacts (presubmits.yaml via make jobs)

/assign @csrwng @sjenning
/cc @enxebre @imain

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

• imain
  • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • ci-operator/step-registry/hypershift/aws/e2e/manual-verify/OWNERS
  • ci-operator/step-registry/hypershift/aws/wait-for-manual-verification/OWNERS
• davidvossel
  • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • ci-operator/step-registry/hypershift/aws/wait-for-manual-verification/OWNERS

[wangke19]

Updated Workflow to Pre-Create Test Cluster

This PR has been updated to create a test cluster before the manual verification wait step.

What Changed

The hypershift-aws-e2e-manual-verify workflow now includes the hypershift-aws-create chain in the pre-phase (instead of creating clusters only during e2e tests):

steps:
  pre:
  - ref: ipi-install-rbac
  - chain: hypershift-setup-nested-management-cluster
  - ref: hypershift-install
  - chain: hypershift-aws-create  # ← Creates HostedCluster with NodePools
  test:
  - ref: hypershift-aws-wait-for-manual-verification  # ← Now clusters exist!
  - ref: hypershift-aws-run-e2e-external

Why This Change

Initial testing showed that the wait step ran before any clusters were created, making it impossible to inspect actual NodePool instances. Now when the wait step executes:

$ oc get hostedcluster -n clusters
NAME          VERSION   AGE
cluster-xxx   4.21.0    5m

$ oc get nodepool -n clusters
NAME                CLUSTER       VERSION   AGE
cluster-xxx-np1     cluster-xxx   4.21.0    4m

$ oc get nodepool -n clusters cluster-xxx-np1 -o jsonpath='{.spec.platform.aws.imageType}'
rhel  # ← Can now verify the imageType field from CNTRLPLANE-408

What Can Be Verified

During the manual verification wait period, you can now:

1. Inspect actual NodePool instances (not just API schema)
2. Verify the imageType field on live NodePools
3. Check NodePool status and conditions
4. View associated Machines (AWS instances)
5. Test oc commands against real clusters

This enables more comprehensive verification of NodePool API changes like the imageType field added in CNTRLPLANE-408.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@wangke19: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hypershift-release-4.21-e2e-aws-manual-verify	openshift/hypershift	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.