Skip to content

test case automation: OCP-84040 #72945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jianli-wei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test case automation: OCP-84040 #72945

jianli-wei wants to merge 1 commit into from

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Dec 25, 2025

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 25, 2025
@openshift-ci openshift-ci bot requested review from gpei and jianlinliu December 25, 2025 03:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 25, 2025

@jianli-wei, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: failed to load registry file /var/tmp/gitrepo1851443333/ci-operator/step-registry/cucushift/installer/rehearse/gcp/cases/valid-dns-private-zone/provision/cucushift-installer-rehearse-gcp-cases-valid-dns-private-zone-provision-ref.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field "documentation"
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianli-wei
Once this PR has been reviewed and has the lgtm label, please assign jianlinliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2025
@jianli-wei jianli-wei force-pushed the OCP-84040 branch 7 times, most recently from 5290e3b to 1a28ca8 Compare December 25, 2025 07:12
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 25, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 25, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 25, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 25, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 25, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 25, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 25, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 25, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei jianli-wei changed the title WIP: OCP-84040 test case automation: OCP-84040 Dec 26, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2025
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 26, 2025
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

@gpei @yunjiang29 please help review, thanks!

yunjiang29
yunjiang29 reviewed Dec 26, 2025
View reviewed changes
...rovision/cucushift-installer-rehearse-gcp-cases-valid-dns-private-zone-provision-commands.sh Outdated
save_artifacts "${install_dir}" "scenario-b"

cmd="gcloud --project ${PRIVATE_ZONE_PROJECT} dns managed-zones delete -q ${expected_zone_name}"
run_command "${cmd}"
Copy link
Contributor

@yunjiang29 yunjiang29 Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is the zone won't be deleted if any errors occurred in this script after zone was created, as errexit was set. Do you consider put it in a trap or deprovision step?

Copy link
Contributor Author

@jianli-wei jianli-wei Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced create cluster with create manifests, so the delete commands should work safely. FYI the rehearsal test.

Copy link
Contributor

@yunjiang29 yunjiang29 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I think the safe way is put it in the trap, we don't know what kind of unexpected error happened in CI system

Copy link
Contributor Author

@jianli-wei jianli-wei Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunjiang29 Could you please see the rehearsal test, and tell if it is what you suggested exactly? Thanks!

Copy link
Contributor

@yunjiang29 yunjiang29 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delete command can be executed if no errors occurred previously. I mean if put it in trap, it will always be executed, like saving script exit code, and prepare_next_steps in install step

Copy link
Contributor Author

@jianli-wei jianli-wei Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if put it in trap, it will always be executed

Do you mean, not run the delete commands, until they are executed in trap?

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 26, 2025
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 26, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 26, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei jianli-wei force-pushed the OCP-84040 branch 3 times, most recently from d7f8a1c to 533c0be Compare December 29, 2025 07:36
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 29, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 29, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 29, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 29, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 30, 2025

[REHEARSALNOTIFIER]
@jianli-wei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 30, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 30, 2025

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 30, 2025

@jianli-wei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14 8e72ec3 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-valid-dns-private-zone-f14

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpei gpei Awaiting requested review from gpei

@jianlinliu jianlinliu Awaiting requested review from jianlinliu

1 more reviewer

@yunjiang29 yunjiang29 yunjiang29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jianli-wei @openshift-ci-robot @yunjiang29