[Resource Sharing]Refactor ResourceProvider to an interface and other ResourceSharing refactors#5755
Merged
cwperks merged 7 commits intoopensearch-project:mainfrom Nov 4, 2025
Conversation
…efactors Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
nibix
previously approved these changes
Oct 31, 2025
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
Overall, changes look good. Left a few comments.
src/main/java/org/opensearch/security/resources/sharing/ResourceSharing.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/securityconf/DynamicConfigFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5755 +/- ##
==========================================
+ Coverage 73.26% 73.30% +0.03%
==========================================
Files 435 434 -1
Lines 26509 26524 +15
Branches 3952 3948 -4
==========================================
+ Hits 19422 19443 +21
+ Misses 5201 5199 -2
+ Partials 1886 1882 -4
🚀 New features to boost your workflow:
|
DarshitChanpura
approved these changes
Nov 4, 2025
RyanL1997
approved these changes
Nov 4, 2025
5 tasks
This was referenced Nov 5, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a few refactors:
indexResourceSharingnow takes the ResourceSharing object as a parameterAll these changes are also included in #5735, but I wanted to do a separate PR to minimize the changes for review so the other PR can be more focused on the functional changes included.
Refactoring
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.