Pass resourceType instead of resourceIndex to resourceSharingClient#1591
Merged
cwperks merged 2 commits intoopensearch-project:mainfrom Nov 4, 2025
Merged
Pass resourceType instead of resourceIndex to resourceSharingClient#1591cwperks merged 2 commits intoopensearch-project:mainfrom
cwperks merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
============================================
- Coverage 81.42% 81.35% -0.08%
+ Complexity 6129 6123 -6
============================================
Files 542 542
Lines 24913 24913
Branches 2541 2541
============================================
- Hits 20286 20268 -18
- Misses 3362 3376 +14
- Partials 1265 1269 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
kaituo
approved these changes
Nov 4, 2025
Member
Author
|
Overriding and merging bc its got necessary approvals and the branch is only one behind the tip of main. This PR blocks other PRs on the repo as it contains a compilation fix after opensearch-project/security#5755 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to the changes in opensearch-project/security#5713 to support multiple resource types in the same index. There's a small change in all ResourceSharingClient methods to accept type in the place of index.
resource type <-> resource index is a many-to-one relationship (think dashboards saved objects where multiple saved object types are in the same index).
On another note, ResourceSharingClient is used in instances where a mechanism doesn't currently exist as in parent<->child relationships (like a detector and results where all results are associated with a detector). Security is working on a mechanism to support this natively to obviate the need for ResourceSharingClient and instead abstract all the logic behind-the-scenes to the security plugin.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.