Fixed some hibernate-query parameter errors, enabled the echart.

[kateyang1998]

Summary by Sourcery

Fix hibernate query parameter indexing errors and enable echart functionality.

Bug Fixes:

• Correct hibernate query parameter indexing to ensure proper query execution.

Enhancements:

• Enable echart functionality in the application.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes Hibernate query parameter indexing issues in CaseManagementNoteDAOImpl.java. The changes update the parameter placeholders from '?' to indexed placeholders '?0', '?1', etc., to ensure correct parameter binding in the HQL queries.

Class diagram for CaseManagementNoteDAOImpl changes

classDiagram
    class CaseManagementNoteDAOImpl {
        +List<CaseManagementNote> getNotes(List<Long> ids)
        +CaseManagementNote getMostRecentNote(String uuid)
        +List<CaseManagementNote> getCPPNotes(String demoNo, long issueId, String uuid)
        +List<CaseManagementNote> getNotesByDemographic(String demographic_no, String uuid)
        +List<CaseManagementNote> getNotesByDemographicSince(String demographic_no, Date date)
        +long getNotesCountByDemographicId(String demographic_no)
        +List<Object[]> getRawNoteInfoByDemographic(String demographic_no)
        +List<Map<String, Object>> getRawNoteInfoMapByDemographic(String demographic_no)
        +List<Map<String, Object>> getUnsignedRawNoteInfoMapByDemographic(String demographic_no)
        +List<CaseManagementNote> searchDemographicNotes(String demographic_no, String searchString)
        +List<CaseManagementNote> getCaseManagementNoteByProgramIdAndObservationDate(Integer programId, Date minObservationDate, Date maxObservationDate)
        +List<CaseManagementNote> getMostRecentNotesByAppointmentNo(int appointmentNo)
        +List<CaseManagementNote> getMostRecentNotes(Integer demographicNo)
        +List<Integer> getNotesByFacilitySince(Date date, List<Program> programs)
        +int getNoteCountForProviderForDateRange(String providerNo, Date startDate, Date endDate)
        +int getNoteCountForProviderForDateRangeWithIssueId(String providerNo, Date startDate, Date endDate, String issueCode)
    }
    note for CaseManagementNoteDAOImpl "Updated HQL queries to use indexed placeholders for parameters."

Loading

File-Level Changes

Change	Details	Files
Updated HQL query parameter placeholders to use indexed parameters	Changed '?' placeholders to indexed placeholders (?0, ?1, etc.) Fixed parameter indexing in getMostRecentNote query Updated parameter placeholders in getCPPNotes query Fixed parameter indexing in getNotesByDemographic queries Updated parameter placeholders in getNotesCountByDemographicId query Fixed parameter indexing in getRawNoteInfo queries Updated parameter placeholders in getActiveNotesByDemographic queries Fixed parameter indexing in SQL queries for note counting functions	src/main/java/org/oscarehr/casemgmt/dao/CaseManagementNoteDAOImpl.java

Possibly linked issues

• Added DownloadInIterceptor import to the classes #1: PR fixes hibernate query parameter errors, which is related to the issue's jpa parameter error.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @kateyang1998 - I've reviewed your changes - here's some feedback:

Overall Comments:

• In getNoteCountForProviderForDateRange(), the SQL query uses ?1, ?2, ?3 but the PreparedStatement uses indices 1,2,3. This mismatch could cause errors - either change the SQL to use ?0, ?1, ?2 or adjust the PreparedStatement indices accordingly.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Parameter numbering inconsistency could cause bugs

The subquery should use ?0 instead of ?1 since it's referring to the same uuid parameter. Using different parameter numbers for the same value could lead to incorrect parameter binding.

[sebastian-j-ibanez]

Both of these parameters should be ?0. They use the same value.

[sourcery-ai]

Hi @sebastian-j-ibanez! 👋

Only authors and team members can run @sourcery-ai commands on public repos.

[sebastian-j-ibanez]

Just one small change to make.

See my comment on the Sourcery comment.

[sebastian-j-ibanez]

Both of these parameters should be ?0. They use the same value.

[sebastian-j-ibanez]

Looks good