Cherry pick changes in PR #14 into alpaca#17
Closed
sebastian-j-ibanez wants to merge 1 commit intodevelop/alpacafrom
Closed
Cherry pick changes in PR #14 into alpaca#17sebastian-j-ibanez wants to merge 1 commit intodevelop/alpacafrom
sebastian-j-ibanez wants to merge 1 commit intodevelop/alpacafrom
Conversation
Reviewer's Guide by SourceryThis PR updates the HQL query parameter placeholders in CaseManagementNoteDAOImpl from the '?' style to the indexed '?n' style (e.g., '?0', '?1', etc.). This change is being cherry-picked from PR #14 to fix a 404 issue in the alpaca branch. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @sebastian-j-ibanez - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/main/java/org/oscarehr/casemgmt/dao/CaseManagementNoteDAOImpl.java
Outdated
Show resolved
Hide resolved
ab04f85 to
89295c5
Compare
Collaborator
Author
|
Closing, PR #18 will include the cherry picked commit instead. |
yingbull
pushed a commit
that referenced
this pull request
May 9, 2025
…ument-descriptions Addressing what happens if HTML is added into a document description
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry picks the changes in #14 to alpaca.
I have built this server and can confirm the changes work.
These changes are needed in alpaca to fix the 404 issue.
Summary by Sourcery
Bug Fixes: