Skip to content

Cherry pick changes in PR #14 into alpaca#17

Closed
sebastian-j-ibanez wants to merge 1 commit intodevelop/alpacafrom
open-o-11-echart-query-alpaca
Closed

Cherry pick changes in PR #14 into alpaca#17
sebastian-j-ibanez wants to merge 1 commit intodevelop/alpacafrom
open-o-11-echart-query-alpaca

Conversation

@sebastian-j-ibanez
Copy link
Copy Markdown
Collaborator

@sebastian-j-ibanez sebastian-j-ibanez commented Nov 8, 2024

This PR cherry picks the changes in #14 to alpaca.

I have built this server and can confirm the changes work.

These changes are needed in alpaca to fix the 404 issue.

Summary by Sourcery

Bug Fixes:

  • Fix parameter indexing in HQL queries to prevent 404 errors in the CaseManagementNoteDAOImpl class.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR updates the HQL query parameter placeholders in CaseManagementNoteDAOImpl from the '?' style to the indexed '?n' style (e.g., '?0', '?1', etc.). This change is being cherry-picked from PR #14 to fix a 404 issue in the alpaca branch.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated HQL query parameter placeholders to use indexed parameters
  • Changed '?' style parameters to indexed '?n' style parameters (e.g., '?0', '?1')
  • Updated parameter placeholders in all HQL queries throughout the class
  • Maintained the same query logic and functionality while only changing the parameter syntax
src/main/java/org/oscarehr/casemgmt/dao/CaseManagementNoteDAOImpl.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sebastian-j-ibanez - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sebastian-j-ibanez sebastian-j-ibanez force-pushed the open-o-11-echart-query-alpaca branch from ab04f85 to 89295c5 Compare November 8, 2024 19:12
@sebastian-j-ibanez
Copy link
Copy Markdown
Collaborator Author

Closing, PR #18 will include the cherry picked commit instead.

@sebastian-j-ibanez sebastian-j-ibanez deleted the open-o-11-echart-query-alpaca branch November 11, 2024 19:00
yingbull pushed a commit that referenced this pull request May 9, 2025
…ument-descriptions

Addressing what happens if HTML is added into a document description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants