8368182: AOT cache creation fails with class defined by JNI

[rm-gh-8]

Backporting JDK-8368182: AOT cache creation fails with class defined by JNI.

This commit fixed the AOT cache to exclude JNI-defined classes by setting their shared_classpath_index to -1 instead of 0, preventing incorrect inclusion in the AOT configuration file. Also updated LambdaFormInvokers::regenerate_holder_classes() to specify a non-null code source, ensuring regenerated holder classes remain included in the cache.

Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/hotspot/jtreg/runtime/cds/appcds/aotCache

Results are attached.

linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log

---

Progress

• Change must not contain extraneous whitespace
• JDK-8368182 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8368182: AOT cache creation fails with class defined by JNI (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/71/head:pull/71
$ git checkout pull/71

Update a local copy of the PR:
$ git checkout pull/71
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/71/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 71

View PR using the GUI difftool:
$ git pr show -t 71

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/71.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368182: AOT cache creation fails with class defined by JNI

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• 4b7defb: 8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes
• 559f805: 8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin
• 53e7ea8: 8370325: G1: Disallow GC for TLAB allocation
• ... and 59 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (919066e8)

[rm-gh-8]

/approval request for backport of JDK-8368182: AOT cache creation fails with class defined by JNI.

This backport has internal customer demand manifesting as an observable build error.

Low-medium risk - fixes a clear bug, but touches critical JVM initialization path.

[openjdk]

@rm-gh-8
8368182: The approval request has been created successfully.

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 919066e) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 687c6a0.
Since your change was applied there have been 63 commits pushed to the master branch:

• dcd89eb: 8368500: ContextClassLoader cannot be reset on threads in ForkJoinPool.commonPool()
• 4b7defb: 8371864: GaloisCounterMode.implGCMCrypt0 AVX512/AVX2 intrinsics stubs cause AES-GCM encryption failure for certain payload sizes
• 559f805: 8369804: TestGenerators.java fails with IllegalArgumentException: bound must be greater than origin
• ... and 60 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @rm-gh-8 Pushed as commit 687c6a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.