-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372759: Test build/AbsPathsInImage.java fails after JDK-8370438 #28676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| endif | ||
|
|
||
| # for lto, we have to use the debug prefix mapping flags to get rid of unwanted paths | ||
| # $1_EXTRA_LDFLAGS += $$(DEBUG_PREFIX_CFLAGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks redundant. It should be enough to add the flags to LDFLAGS_LTO in configure.
|
I can not apply the patch get from https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/28676.diff locallly. Do you mind merge the master first. |
Fei Yang reported this test error on a Debian GNU/Linux 13 (trixie) x86_64 machine:
The lto - built libsplashscreen.so was report to cause this.
To get rid of the unwanted paths in the shared lib (or in debug info files) we should not only compile but also link with debug prefix settings.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28676/head:pull/28676$ git checkout pull/28676Update a local copy of the PR:
$ git checkout pull/28676$ git pull https://git.openjdk.org/jdk.git pull/28676/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28676View PR using the GUI difftool:
$ git pr show -t 28676Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28676.diff
Using Webrev
Link to Webrev Comment