8372554: Test windows-x64-cmp-baseline failed due to differences with splashscreen object file

[prrace]

This backs out a specific part of the change from https://bugs.openjdk.org/browse/JDK-8370438
which causes the windows-x64-cmp-baseline build to fail every time.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372554: Test windows-x64-cmp-baseline failed due to differences with splashscreen object file (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28712/head:pull/28712
$ git checkout pull/28712

Update a local copy of the PR:
$ git checkout pull/28712
$ git pull https://git.openjdk.org/jdk.git pull/28712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28712

View PR using the GUI difftool:
$ git pr show -t 28712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28712.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372554: Test windows-x64-cmp-baseline failed due to differences with splashscreen object file

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• c03d445: 6223700: XP L&F: Non-TopLevel JMenu's painting error
• b86b2cb: 8352914: Shenandoah: Change definition of ShenandoahSharedValue to int32_t to leverage platform atomics
• 8df3f3d: 8373117: Update build doc link in README.md
• ... and 1 more: https://git.openjdk.org/jdk/compare/d34ef196c298aa91f8511714cfb04b15ae7fbf0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following labels will be automatically applied to this pull request:

• build
• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bcf96c1a)

[mrserb]

What is the purpose of the “windows-x64-cmp-baseline” task, and how is it affected by the change in question? Why was the decision made to revert the change instead of fixing the task? Was there something wrong with that optimization?

[mrserb]

This might be related? #28676

[dholmes-ora]

Seems trivially fine to me. Thanks.

[prrace]

/integrate

[openjdk]

Going to push as commit b1c9550.
Since your change was applied there have been 4 commits pushed to the master branch:

• c03d445: 6223700: XP L&F: Non-TopLevel JMenu's painting error
• b86b2cb: 8352914: Shenandoah: Change definition of ShenandoahSharedValue to int32_t to leverage platform atomics
• 8df3f3d: 8373117: Update build doc link in README.md
• ... and 1 more: https://git.openjdk.org/jdk/compare/d34ef196c298aa91f8511714cfb04b15ae7fbf0a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit b1c9550.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[prrace]

What is the purpose of the “windows-x64-cmp-baseline” task, and how is it affected by the change in question? Why was the decision made to revert the change instead of fixing the task? Was there something wrong with that optimization?

SFAIU it checks if builds are reproducible. You can go look for yourself. There's nothing wrong with the "build test/task", the problem is that LTO isn't creating builds that pass on windows x64 and it fails every time.
Could be a windows compiler issue, but that isn't going to get fixed soon. This partial back out is the answer.

Next, if it is important, (which it doesn't seem to be), It is up to whoever wants this LTO option to justify it and make sure everything passes before re-enabling it.

[mrserb]

SFAIU it checks if builds are reproducible. You can go look for yourself.

Does that task use "make COMPARE_BUILD" or call "compare.sh", or do something else? Was only the windows build affected?