Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ Change Log
Unreleased
**********

[1.15.0] - 2025-04-25
---------------------

* Removed edx-braze-client from repo
* Removed braze_push channel from repo

[1.13.0] - 2025-04-25
---------------------

Expand Down
2 changes: 1 addition & 1 deletion edx_ace/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from .recipient import Recipient
from .recipient_resolver import RecipientResolver

__version__ = '1.14.0'
__version__ = '1.15.0'


__all__ = [
Expand Down
10 changes: 5 additions & 5 deletions edx_ace/channel/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

EMAIL = 'email'
PUSH = 'push'
BRAZE_PUSH = 'braze_push'

def __str__(self):
return str(self.value)
Expand Down Expand Up @@ -183,10 +182,11 @@
channel_names = [settings.ACE_CHANNEL_TRANSACTIONAL_EMAIL, settings.ACE_CHANNEL_DEFAULT_EMAIL]
else:
channel_names = [settings.ACE_CHANNEL_DEFAULT_EMAIL]
elif channel_type == ChannelType.PUSH and getattr(settings, "ACE_CHANNEL_DEFAULT_PUSH", None):
channel_names = [settings.ACE_CHANNEL_DEFAULT_PUSH]
elif channel_type == ChannelType.BRAZE_PUSH and getattr(settings, "ACE_CHANNEL_BRAZE_PUSH", None):
channel_names = [settings.ACE_CHANNEL_BRAZE_PUSH]
elif channel_type == ChannelType.PUSH:
if getattr(settings, "ACE_CHANNEL_DEFAULT_PUSH", None):
channel_names = [settings.ACE_CHANNEL_DEFAULT_PUSH]
elif getattr(settings, "ACE_PUSH_CHANNELS", []):
channel_names = settings.ACE_PUSH_CHANNELS

Check warning on line 189 in edx_ace/channel/__init__.py

View check run for this annotation

Codecov / codecov/patch

edx_ace/channel/__init__.py#L189

Added line #L189 was not covered by tests

try:
possible_channels = [
Expand Down
64 changes: 0 additions & 64 deletions edx_ace/channel/braze_push_notification.py

This file was deleted.

1 change: 0 additions & 1 deletion edx_ace/presentation.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
RENDERERS = {
ChannelType.EMAIL: renderers.EmailRenderer(),
ChannelType.PUSH: renderers.PushNotificationRenderer(),
ChannelType.BRAZE_PUSH: renderers.BrazePushNotificationRenderer(),
}


Expand Down
15 changes: 0 additions & 15 deletions edx_ace/renderers.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,18 +99,3 @@ class PushNotificationRenderer(AbstractRenderer):
A renderer for :attr:`.ChannelType.PUSH` channels.
"""
rendered_message_cls = RenderedPushNotification


@attr.s
class RenderedBrazePushNotification:
"""
Encapsulates all values needed to send a :class:`.Message`
over an :attr:`.ChannelType.BRAZE_PUSH`.
"""


class BrazePushNotificationRenderer(AbstractRenderer):
"""
A renderer for :attr:`.ChannelType.PUSH` channels.
"""
rendered_message_cls = RenderedBrazePushNotification
105 changes: 0 additions & 105 deletions edx_ace/tests/channel/test_braze_push_notification.py

This file was deleted.

11 changes: 5 additions & 6 deletions edx_ace/tests/test_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,14 @@ class TestPolicy(TestCase):

# deny only email
PolicyCase(deny_values=[{ChannelType.EMAIL}],
expected_channels={ChannelType.PUSH, ChannelType.BRAZE_PUSH}), # single policy
expected_channels={ChannelType.PUSH}), # single policy
PolicyCase(deny_values=[{ChannelType.EMAIL}, set()],
expected_channels={ChannelType.PUSH, ChannelType.BRAZE_PUSH}), # multiple policies
expected_channels={ChannelType.PUSH}), # multiple policies

# deny email, push and braze_push
PolicyCase(deny_values=[{ChannelType.EMAIL, ChannelType.PUSH, ChannelType.BRAZE_PUSH}],
# deny email and push
PolicyCase(deny_values=[{ChannelType.EMAIL, ChannelType.PUSH}],
expected_channels=set()), # single policy
PolicyCase(deny_values=[{ChannelType.EMAIL}, {ChannelType.PUSH},
{ChannelType.BRAZE_PUSH}], expected_channels=set()), # multiple policies
PolicyCase(deny_values=[{ChannelType.EMAIL}, {ChannelType.PUSH}], expected_channels=set()), # multiple policies

# deny all and email
PolicyCase(deny_values=[{ChannelType.EMAIL}, set(ChannelType)], expected_channels=set()),
Expand Down
59 changes: 0 additions & 59 deletions edx_ace/tests/utils/test_braze_utils.py

This file was deleted.

27 changes: 0 additions & 27 deletions edx_ace/utils/braze.py

This file was deleted.

1 change: 0 additions & 1 deletion requirements/dev.in
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ tox # virtualenv management for tests
twine # Utility for PyPI package uploads
wheel # For generation of wheels for PyPI
backports.zoneinfo; python_version<'3.9' # Needed for Python 3.12 compatibility
edx-braze-client==1.0.2
8 changes: 1 addition & 7 deletions requirements/dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ django==4.2.20
# django-crum
# django-push-notifications
# django-waffle
# edx-braze-client
# edx-django-utils
# edx-i18n-tools
django-crum==0.7.9
Expand All @@ -71,12 +70,8 @@ django-waffle==4.2.0
# via edx-django-utils
docutils==0.21.2
# via readme-renderer
edx-braze-client==1.0.2
# via -r requirements/dev.in
edx-django-utils==7.4.0
# via
# -r requirements/base.in
# edx-braze-client
# via -r requirements/base.in
edx-i18n-tools==1.8.0
# via -r requirements/dev.in
edx-lint==5.6.0
Expand Down Expand Up @@ -272,7 +267,6 @@ readme-renderer==44.0
requests==2.32.3
# via
# cachecontrol
# edx-braze-client
# google-api-core
# google-cloud-storage
# id
Expand Down
1 change: 0 additions & 1 deletion requirements/doc.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ readme_renderer # Validates README.rst for usage on PyPI
Sphinx # Documentation builder
twine
backports.zoneinfo; python_version<'3.9' # Needed for Python 3.12 compatibility
edx-braze-client==1.0.2
Loading