fix: Moved braze push channel to edx-braze-client#360
Merged
AhtishamShahid merged 5 commits intoopenedx:masterfrom Jun 25, 2025
Merged
Conversation
AhtishamShahid
approved these changes
Jun 19, 2025
kdmccormick
approved these changes
Jun 19, 2025
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
This is great. Just one comment suggestion, and please also add a changelog entry and use conventional commit notation to mark this as a breaking fix (fix!:).
| @@ -166,7 +165,6 @@ def is_requirement(line): | |||
| 'file_email = edx_ace.channel.file:FileEmailChannel', | |||
Member
There was a problem hiding this comment.
Suggested change
| 'file_email = edx_ace.channel.file:FileEmailChannel', | |
| # We define some default channels here in edx-ace. | |
| # These should be generic, non-vendor-specific channels. | |
| # If you have vendor-specific channels, you can add them using this entrypoint, | |
| # but please do so in a separate plugin repository. The braze_email and sailthru_email | |
| # channels listed above were added before this rule; they are not a pattern to follow. | |
| 'file_email = edx_ace.channel.file:FileEmailChannel', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We don't want openedx to have any reference with braze therefore this PR is moving braze push channel to edx-braze-client. In edx-braze-client we will introduce this channel through openedx.ace.channel extension point.
JIRA: Link to JIRA ticket
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline:
ASAP.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.