Make thread unsubscribe test deterministic#18000
Open
starr-openai wants to merge 2 commits intomainfrom
Open
Conversation
Gate the app-server unsubscribe-during-turn test on the mocked Responses request reaching the streaming SSE server instead of sleeping and polling for a second request. Add request-count notification support to the streaming SSE test server so the test can wait for the in-flight turn deterministically before unsubscribing. Co-authored-by: Codex <noreply@openai.com>
Replace the gated assistant-only response with a dynamic tool call that the test holds open across thread/unsubscribe. This keeps the test deterministic while proving the turn continues once the unresolved tool call is released. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
approved these changes
Apr 15, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Validation