Skip to content

Fix Windows marketplace paths and shell command strings#18019

Draft
jgershen-oai wants to merge 1 commit intostarr/deterministic-thread-unsubscribefrom
codex/windows-path-shell-on-pr18000
Draft

Fix Windows marketplace paths and shell command strings#18019
jgershen-oai wants to merge 1 commit intostarr/deterministic-thread-unsubscribefrom
codex/windows-path-shell-on-pr18000

Conversation

@jgershen-oai
Copy link
Copy Markdown
Collaborator

Summary

  • treat Windows backslash-relative/rooted marketplace sources as local paths
  • keep the local marketplace config test on structured TOML access so Windows backslashes are not interpreted through indexing/string escapes
  • add a test helper for shell_command responses that accepts an already-constructed raw command string, preserving Windows PowerShell quoting semantics

Stack

Validation

  • just fmt
  • cargo test -p codex-core marketplace_add
  • cargo test -p codex-cli marketplace_add
  • cargo test -p codex-app-server suite::v2::thread_unsubscribe::thread_unsubscribe_during_turn_keeps_turn_running -- --exact
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant