Skip to content

chore: 1.0 flagd core transitive deps #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 1 commit into from
Apr 2, 2026
+1 −2
Merged

chore: 1.0 flagd core transitive deps #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/flagd/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<protobuf-java.min.version>3.25.6</protobuf-java.min.version>
<com.vmlens.version>1.2.27</com.vmlens.version>
<!-- Transitive flagd-core version -->
<flagd-core.version>0.2.0</flagd-core.version>
<flagd-core.version>[1.0.0,2.0.0)</flagd-core.version>
Comment on lines 23 to +24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment describes flagd-core as a transitive dependency, but it is actually declared as a direct dependency of this provider (see line 46). While the goal is to stabilize transitive dependencies of flagd-core, the property itself refers to a direct dependency of this module. Consider updating the comment for clarity.

</properties>

<name>flagd</name>
Expand Down
1 change: 0 additions & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@
"tools/flagd-core": {
"package-name": "dev.openfeature.contrib.tools.flagdcore",
"release-type": "simple",
"release-as": "1.0.0",
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": true,
"versioning": "default",
Expand Down
Loading