Merged
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the flagd-core version range to [1.0.0,2.0.0) in the flagd provider and removes the fixed release version for flagd-core in the release configuration. Feedback was provided regarding a comment in the POM file that incorrectly identifies flagd-core as a transitive dependency instead of a direct one.
Comment on lines
23
to
+24
| <!-- Transitive flagd-core version --> | ||
| <flagd-core.version>0.2.0</flagd-core.version> | ||
| <flagd-core.version>[1.0.0,2.0.0)</flagd-core.version> |
Contributor
There was a problem hiding this comment.
The comment describes flagd-core as a transitive dependency, but it is actually declared as a direct dependency of this provider (see line 46). While the goal is to stabilize transitive dependencies of flagd-core, the property itself refers to a direct dependency of this module. Consider updating the comment for clarity.
toddbaert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizing our flagd core/api transitive deps so we can set meaningful upper bounds on them to protect us from breaking changes.