Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"providers/ofrep": "0.0.1",
"tools/junit-openfeature": "0.2.1",
"tools/flagd-http-connector": "0.0.4",
"tools/flagd-api": "0.1.0",
"tools/flagd-api": "1.0.0",
"tools/flagd-api-testkit": "0.2.1",
"tools/flagd-core": "0.2.0",
".": "1.0.0"
Expand Down
7 changes: 7 additions & 0 deletions tools/flagd-api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [1.0.0](https://github.com/open-feature/java-sdk-contrib/compare/dev.openfeature.contrib.tools.flagdapi-v0.1.0...dev.openfeature.contrib.tools.flagdapi-v1.0.0) (2026-04-02)


### ✨ New Features

* 1.0 flagd core transitive deps ([#1755](https://github.com/open-feature/java-sdk-contrib/issues/1755)) ([fec3753](https://github.com/open-feature/java-sdk-contrib/commit/fec3753c34785c4dc911441def6686ff666bcc08))

## [0.1.0](https://github.com/open-feature/java-sdk-contrib/compare/dev.openfeature.contrib.tools.flagdapi-v0.0.2...dev.openfeature.contrib.tools.flagdapi-v0.1.0) (2026-03-11)


Expand Down
26 changes: 10 additions & 16 deletions tools/flagd-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,29 @@ The `flagd-api` module defines the core interfaces that can be implemented by di
<dependency>
<groupId>dev.openfeature.contrib.tools</groupId>
<artifactId>flagd-api</artifactId>
<version>0.1.0</version> <!--x-release-please-version -->
<version>1.0.0</version> <!--x-release-please-version -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation in the 'Interfaces' section (lines 30-49) is significantly out of sync with the actual code in Evaluator.java.

  • The Evaluator interface methods in the README are missing the defaultValue parameter.
  • The README describes a separate FlagStore interface, but in the code, these methods (setFlags, setFlagsAndGetChangedKeys, getFlagSetMetadata) have been merged into the Evaluator interface.

Since this is a 1.0.0 release, it is important that the primary documentation accurately reflects the API to avoid confusing users.

</dependency>
```

## Interfaces

### Evaluator

The `Evaluator` interface handles flag resolution:
The `Evaluator` interface handles flag storage and resolution:

```java
public interface Evaluator {
ProviderEvaluation<Boolean> resolveBooleanValue(String flagKey, EvaluationContext ctx);
ProviderEvaluation<String> resolveStringValue(String flagKey, EvaluationContext ctx);
ProviderEvaluation<Integer> resolveIntegerValue(String flagKey, EvaluationContext ctx);
ProviderEvaluation<Double> resolveDoubleValue(String flagKey, EvaluationContext ctx);
ProviderEvaluation<Value> resolveObjectValue(String flagKey, EvaluationContext ctx);
}
```

### FlagStore

The `FlagStore` interface handles flag configuration storage and updates:

```java
public interface FlagStore {
// flag store methods
void setFlags(String flagConfigurationJson) throws FlagStoreException;
List<String> setFlagsAndGetChangedKeys(String flagConfigurationJson) throws FlagStoreException;
Map<String, Object> getFlagSetMetadata();

// flag evaluation methods
ProviderEvaluation<Boolean> resolveBooleanValue(String flagKey, Boolean defaultValue, EvaluationContext ctx);
ProviderEvaluation<String> resolveStringValue(String flagKey, String defaultValue, EvaluationContext ctx);
ProviderEvaluation<Integer> resolveIntegerValue(String flagKey, Integer defaultValue, EvaluationContext ctx);
ProviderEvaluation<Double> resolveDoubleValue(String flagKey, Double defaultValue, EvaluationContext ctx);
ProviderEvaluation<Value> resolveObjectValue(String flagKey, Value defaultValue, EvaluationContext ctx);
}
```

Expand Down
2 changes: 1 addition & 1 deletion tools/flagd-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</parent>
<groupId>dev.openfeature.contrib.tools</groupId>
<artifactId>flagd-api</artifactId>
<version>0.1.0</version> <!--x-release-please-version -->
<version>1.0.0</version> <!--x-release-please-version -->

<properties>
<module-name>${groupId}.flagdapi</module-name>
Expand Down
2 changes: 1 addition & 1 deletion tools/flagd-api/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.0
1.0.0
Loading