Conversation
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version of the flagd-api tool from 0.1.0 to 1.0.0 across the manifest, changelog, README, pom.xml, and version files. A review comment identifies that the documentation in the README's 'Interfaces' section is significantly out of sync with the actual code, specifically regarding missing parameters and merged interfaces, which should be addressed for this major release.
| <groupId>dev.openfeature.contrib.tools</groupId> | ||
| <artifactId>flagd-api</artifactId> | ||
| <version>0.1.0</version> <!--x-release-please-version --> | ||
| <version>1.0.0</version> <!--x-release-please-version --> |
There was a problem hiding this comment.
The documentation in the 'Interfaces' section (lines 30-49) is significantly out of sync with the actual code in Evaluator.java.
- The
Evaluatorinterface methods in the README are missing thedefaultValueparameter. - The README describes a separate
FlagStoreinterface, but in the code, these methods (setFlags,setFlagsAndGetChangedKeys,getFlagSetMetadata) have been merged into theEvaluatorinterface.
Since this is a 1.0.0 release, it is important that the primary documentation accurately reflects the API to avoid confusing users.
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
deleted the
release-please--branches--main--components--dev.openfeature.contrib.tools.flagdapi
branch
|
🤖 Created releases: 🌻 |
2 participants
🤖 I have created a release beep boop
1.0.0 (2026-04-02)
✨ New Features
This PR was generated with Release Please. See documentation.