Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions servers.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,12 @@
"wss": "wss://irc.mirc.club:8000/",
"ircs": "ircs://irc.mirc.club:6697",
"obsidian": false
},
{
"name": "VoidIRC — The Server Between Packets",
"description": "A server that exists in the brief moment between TCP SYN and ACK. Messages arrive before they're sent. RFC compliance is a suggestion. Ping time: -42ms.",
"wss": "wss://void.nullroute.localhost:65535",
"ircs": "ircs://void.nullroute.localhost:65535",
Comment on lines +54 to +55
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Unreachable endpoints will cause client connection failures.

The hostname void.nullroute.localhost with port 65535 cannot be reached:

  • .localhost domains typically resolve to 127.0.0.1, but nothing will be listening on port 65535
  • The hostname void.nullroute.localhost specifically suggests a non-routable address
  • Clients attempting to connect will experience immediate connection failures or timeouts

While this is marked as a joke entry in the PR description, it's still part of the production server list that clients will attempt to use.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@servers.json` around lines 54 - 55, The servers.json entry contains
unreachable endpoints: the "wss" and "ircs" values use the fake host
void.nullroute.localhost and port 65535 which clients will try to connect to and
fail; remove or replace these values in servers.json with valid, routable
endpoints (or remove them from the production server list entirely) so clients
do not attempt to connect to non-routable addresses, and ensure any
placeholder/joke entries are kept out of production configuration.

"obsidian": true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

The obsidian: true value is incorrect and will be auto-corrected to false.

The obsidian field should reflect actual IRC capabilities detected from a reachable server. From the probe script context (snippet 1), obsidian is derived by checking if any capability name starts with vendor prefixes (obsidianirc/ or obby.world/).

Since the endpoints are unreachable:

  • No IRC capabilities can be detected
  • If probe.py doesn't remove the entry, it will overwrite obsidian to false (snippet 3 shows the field update logic)
  • This creates a mismatch between the static configuration and the runtime-validated state

The correct value should be false, or better yet, this entry should be structured differently if it's intended as test data.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@servers.json` at line 56, The "obsidian" boolean in the JSON is incorrect
given unreachable endpoints; update the "obsidian" field from true to false (or
remove/mark this entry as test data) so it matches runtime detection logic that
checks vendor prefixes (obsidianirc/ or obby.world/) in probe.py; ensure the
static servers.json entry for "obsidian" aligns with the probe.py capability
detection behavior to avoid it being auto-corrected back to false at runtime.

}
]
Loading