Add VoidIRC — The Server Between Packets#17
Conversation
📝 WalkthroughWalkthroughA new IRC server configuration entry named "VoidIRC — The Server Between Packets" is added to ChangesVoidIRC Server Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
Server list probeScope: 1 server(s) changed vs
Failed — unreachable on every transport
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@servers.json`:
- Line 56: The "obsidian" boolean in the JSON is incorrect given unreachable
endpoints; update the "obsidian" field from true to false (or remove/mark this
entry as test data) so it matches runtime detection logic that checks vendor
prefixes (obsidianirc/ or obby.world/) in probe.py; ensure the static
servers.json entry for "obsidian" aligns with the probe.py capability detection
behavior to avoid it being auto-corrected back to false at runtime.
- Around line 54-55: The servers.json entry contains unreachable endpoints: the
"wss" and "ircs" values use the fake host void.nullroute.localhost and port
65535 which clients will try to connect to and fail; remove or replace these
values in servers.json with valid, routable endpoints (or remove them from the
production server list entirely) so clients do not attempt to connect to
non-routable addresses, and ensure any placeholder/joke entries are kept out of
production configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| "wss": "wss://void.nullroute.localhost:65535", | ||
| "ircs": "ircs://void.nullroute.localhost:65535", |
There was a problem hiding this comment.
Unreachable endpoints will cause client connection failures.
The hostname void.nullroute.localhost with port 65535 cannot be reached:
.localhostdomains typically resolve to127.0.0.1, but nothing will be listening on port 65535- The hostname
void.nullroute.localhostspecifically suggests a non-routable address - Clients attempting to connect will experience immediate connection failures or timeouts
While this is marked as a joke entry in the PR description, it's still part of the production server list that clients will attempt to use.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@servers.json` around lines 54 - 55, The servers.json entry contains
unreachable endpoints: the "wss" and "ircs" values use the fake host
void.nullroute.localhost and port 65535 which clients will try to connect to and
fail; remove or replace these values in servers.json with valid, routable
endpoints (or remove them from the production server list entirely) so clients
do not attempt to connect to non-routable addresses, and ensure any
placeholder/joke entries are kept out of production configuration.
| "description": "A server that exists in the brief moment between TCP SYN and ACK. Messages arrive before they're sent. RFC compliance is a suggestion. Ping time: -42ms.", | ||
| "wss": "wss://void.nullroute.localhost:65535", | ||
| "ircs": "ircs://void.nullroute.localhost:65535", | ||
| "obsidian": true |
There was a problem hiding this comment.
The obsidian: true value is incorrect and will be auto-corrected to false.
The obsidian field should reflect actual IRC capabilities detected from a reachable server. From the probe script context (snippet 1), obsidian is derived by checking if any capability name starts with vendor prefixes (obsidianirc/ or obby.world/).
Since the endpoints are unreachable:
- No IRC capabilities can be detected
- If probe.py doesn't remove the entry, it will overwrite
obsidiantofalse(snippet 3 shows the field update logic) - This creates a mismatch between the static configuration and the runtime-validated state
The correct value should be false, or better yet, this entry should be structured differently if it's intended as test data.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@servers.json` at line 56, The "obsidian" boolean in the JSON is incorrect
given unreachable endpoints; update the "obsidian" field from true to false (or
remove/mark this entry as test data) so it matches runtime detection logic that
checks vendor prefixes (obsidianirc/ or obby.world/) in probe.py; ensure the
static servers.json entry for "obsidian" aligns with the probe.py capability
detection behavior to avoid it being auto-corrected back to false at runtime.
1 participant
Summary
Adds VoidIRC — The Server Between Packets, a fake IRC server that exists in the liminal space between TCP packets.
Server Details
wss://void.nullroute.localhost:65535ircs://void.nullroute.localhost:65535true(obviously)Technical Notes
Summary by CodeRabbit