Skip to content

fix(google-maps): prevent blank space during page transitions #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harlan-zw wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(google-maps): prevent blank space during page transitions #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/script/src/runtime/components/GoogleMaps/ScriptGoogleMaps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,11 @@ onBeforeUnmount(() => {
// so anything after an `await` runs as a detached microtask.
// Note: do NOT null mapsApi here — children unmount AFTER onBeforeUnmount
// and need mapsApi.value for clearInstanceListeners in their cleanup.
// Note: do NOT remove map DOM here — during page transitions the leave
// animation is still playing, and tearing out the iframe leaves blank
// space. Vue removes the parent element on actual unmount.
map.value?.unbindAll()
map.value = undefined
mapEl.value?.firstChild?.remove()
libraries.clear()
queryToLatLngCache.clear()
})
Expand Down
Loading