fix(google-maps): prevent blank space during page transitions#715
fix(google-maps): prevent blank space during page transitions#715
Conversation
Removing the map DOM in onBeforeUnmount caused a visible blank space while the leave animation was playing, because Vue removes the parent element on actual unmount. Let Vue handle DOM cleanup instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change modifies the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
Resolves #714
❓ Type of change
📚 Description
ScriptGoogleMapsremoved its map DOM (mapEl.value?.firstChild?.remove()) insideonBeforeUnmount, which fired while the page-transition leave animation was still playing and left a blank area where the map used to be. Vue already removes the parent element on actual unmount, so dropping the manual DOM removal lets the map stay visible through the transition.