Canonical AA v0.7 Support#776
Closed
derekpierre wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## signing-epic #776 +/- ##
===============================================
Coverage ? 90.29%
===============================================
Files ? 98
Lines ? 8678
Branches ? 316
===============================================
Hits ? 7836
Misses ? 839
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds Canonical AA v0.7 signing support to the TACo web monorepo primarily by upgrading @nucypher/nucypher-core and extending the signing test matrix to cover AA 0.7.0.
Changes:
- Bump
@nucypher/nucypher-corefrom0.15.1-dev.3to0.15.1-dev.4across the repo (including lockfile + overrides). - Extend
signUserOpAA version typing to include0.7.0. - Add
0.7.0coverage tosignUserOptests for both UserOperation and PackedUserOperation.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates lockfile resolutions/snapshots for @nucypher/nucypher-core@0.15.1-dev.4. |
| package.json | Bumps root dependency + override for @nucypher/nucypher-core to dev.4. |
| packages/shared/package.json | Bumps @nucypher/nucypher-core dependency to dev.4. |
| packages/taco/package.json | Bumps @nucypher/nucypher-core dependency to dev.4. |
| packages/taco/src/sign.ts | Extends aaVersion type annotation to include 0.7.0. |
| packages/taco/test/taco-sign.test.ts | Adds 0.7.0 to the valid AA version test matrix; minor formatting change for mock call extraction. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
package.json:72
@nucypher/nucypher-coreis bumped via the root dependency andpnpm.overrides, but some workspace packages still declare^0.15.1-dev.3(e.g.packages/pre/package.jsonandpackages/test-utils/package.json). Even though the override forces resolution, the mismatched declared ranges can be confusing and can break if overrides are changed/removed; consider updating those package.json files to^0.15.1-dev.4for consistency.
},
"overrides": {
"@nucypher/nucypher-core": "^0.15.1-dev.4",
"glob-parent@<5.1.2": ">=5.1.2",
"node-forge@<1.0.0": ">=1.0.0",
"node-forge@<1.3.0": ">=1.3.0",
"nth-check@<2.0.1": ">=2.0.1"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theref
approved these changes
Apr 17, 2026
… parameter Update test.
59c43c0 to
746ba48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Add support for canonical AA v0.7 signing.
Issues fixed/closed:
Why it's needed:
Notes for reviewers: