Skip to content

Canonical AA v0.7 Support#776

Closed
derekpierre wants to merge 3 commits into
nucypher:signing-epicfrom
derekpierre:canonical-v07
Closed

Canonical AA v0.7 Support#776
derekpierre wants to merge 3 commits into
nucypher:signing-epicfrom
derekpierre:canonical-v07

Conversation

@derekpierre
Copy link
Copy Markdown
Member

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Add support for canonical AA v0.7 signing.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (signing-epic@1571af3). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             signing-epic     #776   +/-   ##
===============================================
  Coverage                ?   90.29%           
===============================================
  Files                   ?       98           
  Lines                   ?     8678           
  Branches                ?      316           
===============================================
  Hits                    ?     7836           
  Misses                  ?      839           
  Partials                ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Canonical AA v0.7 signing support to the TACo web monorepo primarily by upgrading @nucypher/nucypher-core and extending the signing test matrix to cover AA 0.7.0.

Changes:

  • Bump @nucypher/nucypher-core from 0.15.1-dev.3 to 0.15.1-dev.4 across the repo (including lockfile + overrides).
  • Extend signUserOp AA version typing to include 0.7.0.
  • Add 0.7.0 coverage to signUserOp tests for both UserOperation and PackedUserOperation.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-lock.yaml Updates lockfile resolutions/snapshots for @nucypher/nucypher-core@0.15.1-dev.4.
package.json Bumps root dependency + override for @nucypher/nucypher-core to dev.4.
packages/shared/package.json Bumps @nucypher/nucypher-core dependency to dev.4.
packages/taco/package.json Bumps @nucypher/nucypher-core dependency to dev.4.
packages/taco/src/sign.ts Extends aaVersion type annotation to include 0.7.0.
packages/taco/test/taco-sign.test.ts Adds 0.7.0 to the valid AA version test matrix; minor formatting change for mock call extraction.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

package.json:72

  • @nucypher/nucypher-core is bumped via the root dependency and pnpm.overrides, but some workspace packages still declare ^0.15.1-dev.3 (e.g. packages/pre/package.json and packages/test-utils/package.json). Even though the override forces resolution, the mismatched declared ranges can be confusing and can break if overrides are changed/removed; consider updating those package.json files to ^0.15.1-dev.4 for consistency.
    },
    "overrides": {
      "@nucypher/nucypher-core": "^0.15.1-dev.4",
      "glob-parent@<5.1.2": ">=5.1.2",
      "node-forge@<1.0.0": ">=1.0.0",
      "node-forge@<1.3.0": ">=1.3.0",
      "nth-check@<2.0.1": ">=2.0.1"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/taco/src/sign.ts
@derekpierre derekpierre mentioned this pull request Apr 16, 2026
35 tasks
@derekpierre derekpierre changed the title [WIP] Canonical AA v0.7 Support Canonical AA v0.7 Support Apr 17, 2026
@derekpierre derekpierre marked this pull request as ready for review April 17, 2026 13:54
@derekpierre derekpierre self-assigned this Apr 17, 2026
@derekpierre derekpierre mentioned this pull request Apr 20, 2026
20 tasks
@derekpierre derekpierre deleted the branch nucypher:signing-epic April 21, 2026 12:31
@derekpierre derekpierre mentioned this pull request Apr 21, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants